Skip to content

Commit d44db6e

Browse files
authored
move default modules from /modules/default to /defaultmodules (#4019)
Since the project's inception, I've missed a clear separation between default and third-party modules. This increases complexity within the project (exclude `modules`, but not `modules/default`), but the mixed use is particularly problematic in Docker setups. Therefore, with this pull request, I'm moving the default modules to a different directory. ~~I've chosen `default/modules`, but I'm not bothered about it; `defaultmodules` or something similar would work just as well.~~ Changed to `defaultmodules`. Let me know if there's a majority in favor of this change.
1 parent 5e0cd28 commit d44db6e

File tree

113 files changed

+59
-40
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

113 files changed

+59
-40
lines changed

.gitignore

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,8 @@ Temporary Items
5454
.directory
5555
.Trash-*
5656

57-
# Ignore all modules except the default modules.
57+
# Ignore all modules
5858
/modules/*
59-
!/modules/default
6059

6160
# Ignore changes to the custom css files but keep the sample and main.
6261
/css/*

cspell.config.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -343,11 +343,11 @@
343343
"ignorePaths": [
344344
"css/roboto.css",
345345
"node_modules/**",
346-
"modules/!(default)/**",
347-
"modules/default/**/translations/!(en).json",
348-
"modules/default/calendar/windowsZones.json",
349-
"modules/default/clock/faces/*.svg",
350-
"modules/default/weather/providers/yr.js",
346+
"modules/**",
347+
"defaultmodules/**/translations/!(en).json",
348+
"defaultmodules/calendar/windowsZones.json",
349+
"defaultmodules/clock/faces/*.svg",
350+
"defaultmodules/weather/providers/yr.js",
351351
"tests/mocks/**",
352352
"tests/e2e/modules/clock_es_spec.js",
353353
"translations/**"
File renamed without changes.

0 commit comments

Comments
 (0)