Skip to content

Commit f0393c3

Browse files
Merge branch 'develop' into update-subclass-language-use-override
2 parents 1b65802 + 3b79791 commit f0393c3

File tree

6 files changed

+22
-231
lines changed

6 files changed

+22
-231
lines changed

.gitignore

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ lib-cov
99
coverage
1010
.lock-wscript
1111
build/Release
12-
/node_modules/**/*
13-
!/tests/node_modules/**/*
12+
node_modules
1413
jspm_modules
1514
.npm
1615
.node_repl_history
@@ -56,21 +55,15 @@ Temporary Items
5655
.Trash-*
5756

5857
# Ignore all modules except the default modules.
59-
/modules/**
60-
!/modules/default
61-
!/modules/default/**
62-
!/modules/README.md**
58+
modules
59+
!modules/default
6360

64-
# Ignore changes to the custom css files but keep the sample and main.
65-
/css/*
66-
!/css/custom.css.sample
67-
!/css/main.css
68-
!/css/roboto.css
69-
!/css/font-awesome.css
61+
# Ignore changes to the custom css files but keep others.
62+
css/custom.css
7063

7164
# Ignore users config file but keep the sample.
72-
/config/*
73-
!/config/config.js.sample
65+
config
66+
!config/config.js.sample
7467

7568
# Vim
7669
## swap

CHANGELOG.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ planned for 2026-01-01
1616
- [weather] feat: add configurable forecast date format option (#3918)
1717
- [core] Add new `server:watch` script to run MagicMirror² server-only with automatic restarts when files (defined in `config.watchTargets`) change (#3920)
1818

19+
### Removed
20+
21+
- [weather] Removed deprecated ukmetoffice datapoint provider (#3842, #3952)
22+
1923
### Changed
2024

2125
- [core] refactor: replace `module-alias` dependency with internal alias resolver (#3893)
@@ -25,6 +29,7 @@ planned for 2026-01-01
2529
- [tests] migrate from `jest` to `vitest` (#3940, #3941)
2630
- [ci] Add concurrency to automated tests workflow to cancel outdated runs (#3943)
2731
- [tests] replace `node-libgpiod` with `serialport` in electron-rebuild workflow (#3945)
32+
- [calendar] hide repeatingCountTitle if the event count is zero (#3949)
2833
- [weatherprovider] update override warning wording (#3914)
2934

3035
### Fixed
@@ -34,10 +39,11 @@ planned for 2026-01-01
3439
- [core] refactor: replace `express-ipfilter` with lightweight custom middleware (#3917) - This fixes security issue [CVE-2023-42282](https://github.com/advisories/GHSA-78xj-cgh5-2h22), which is not very likely to be exploitable in MagicMirror² setups, but still should be fixed.
3540
- fixed the Environment Canada weather URL (#3912) and now converts a windspeed of 'calm' to 0
3641
- fixed problems with daylight-saving-time in weather provider `openmeto` (#3930, #3931)
42+
- [newsfeed] fixed header layout issue introduced with prettier njk linting (#3946)
3743

3844
### Updated
3945

40-
- [core] Update dependencies (#3909, #3916, #3921, #3925, #3934)
46+
- [core] Update dependencies incl. electron to v39 (#3909, #3916, #3921, #3925, #3934)
4147
- [logger] Add prefixes to most Log messages (#3923, #3926)
4248

4349
## [2.33.0] - 2025-10-01

modules/default/calendar/calendar.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,9 @@ Module.register("calendar", {
330330
const thisYear = eventStartDateMoment.year(),
331331
yearDiff = thisYear - event.firstYear;
332332

333-
repeatingCountTitle = `, ${yearDiff} ${repeatingCountTitle}`;
333+
if (yearDiff > 0) {
334+
repeatingCountTitle = `, ${yearDiff} ${repeatingCountTitle}`;
335+
}
334336
}
335337
}
336338

modules/default/newsfeed/newsfeed.njk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
{% if (config.showSourceTitle and item.sourceTitle) or config.showPublishDate %}
4141
<div class="newsfeed-source light small dimmed">
4242
{% if item.sourceTitle and config.showSourceTitle %}
43-
{{ item.sourceTitle }}{% if config.showPublishDate %},{% else %}:{% endif %}
43+
{{ item.sourceTitle }}{% if config.showPublishDate %},&nbsp;{% else %}:{% endif %}
4444
{% endif %}
4545
{% if config.showPublishDate %}{{ item.publishDate }}:{% endif %}
4646
</div>
@@ -63,7 +63,7 @@
6363
{% if (config.showSourceTitle and sourceTitle) or config.showPublishDate %}
6464
<div class="newsfeed-source light small dimmed">
6565
{% if sourceTitle and config.showSourceTitle %}
66-
{{ escapeText(sourceTitle, config.dangerouslyDisableAutoEscaping) }}{% if config.showPublishDate %},{% else %}:{% endif %}
66+
{{ escapeText(sourceTitle, config.dangerouslyDisableAutoEscaping) }}{% if config.showPublishDate %},&nbsp;{% else %}:{% endif %}
6767
{% endif %}
6868
{% if config.showPublishDate %}{{ publishDate }}:{% endif %}
6969
</div>

modules/default/weather/providers/ukmetoffice.js

Lines changed: 0 additions & 211 deletions
This file was deleted.

tests/electron/env_spec.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ describe("Electron app environment", () => {
1111
});
1212

1313
it("should open browserwindow", async () => {
14-
const module = await helpers.getElement("#module_0_helloworld");
15-
await expect(module.textContent()).resolves.toContain("Test Display Header");
14+
// Wait for module content to be rendered, not just the module wrapper
15+
const moduleContent = await helpers.getElement("#module_0_helloworld .module-content");
16+
await expect(moduleContent.textContent()).resolves.toContain("Test Display Header");
1617
expect(global.electronApp.windows()).toHaveLength(1);
1718
});
1819
});

0 commit comments

Comments
 (0)