Protect EnvironmentConfig autoload from an endless loop.

Author: MagicPush

src/Parametizer/EnvironmentConfig.php

@@ -163,7 +163,12 @@ public static function createFromConfigsBottomUpHierarchy(
                 return $envConfig;
             }
 
-            $currentDirPath = dirname($currentDirPath);
+            $previousDirPath = $currentDirPath;
+            $currentDirPath  = dirname($currentDirPath);
+            // Prevents a possible endless loop, if `$topmostDirectoryPath` is unreachable:
+            if ($currentDirPath === $previousDirPath) {
+                return $envConfig;
+            }
         }
     }
 

tests/Tests/Parametizer/EnvironmentConfig/EnvironmentConfigTest.php

@@ -226,4 +226,15 @@ public static function provideThrowingOnExceptions(): array {
             ],
         ];
     }
+
+    /**
+     * Tests no endless loop happens if a topmost directory is unreachable (exists in another files branch).
+     *
+     * This test should execute momentarily, unless an endless loop happens.
+     *
+     * @covers EnvironmentConfig::createFromConfigsBottomUpHierarchy()
+     */
+    public function testUnreachableTopmost(): void {
+        assertSame('', self::assertNoErrorsOutput(__DIR__ . '/autoload/unreachable-topmost.php')->getStdOut());
+    }
 }

tests/Tests/Parametizer/EnvironmentConfig/autoload/unreachable-topmost.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use MagicPush\CliToolkit\Parametizer\EnvironmentConfig;
+
+require_once __DIR__ . '/../../../init-console.php';
+
+// Simulates a case, where config files search continues until the top of a file system is reached.
+EnvironmentConfig::createFromConfigsBottomUpHierarchy('/var/log', '/tmp', true);

tests/Tests/init-console.php

@@ -6,3 +6,4 @@
 
 mb_internal_encoding('UTF-8');
 setlocale(LC_ALL, 'en_US.UTF-8');
+ini_set('max_execution_time', 2);