add cython as a build dependency

Author: ngoldbaum

.github/workflows/tests.yml

@@ -47,4 +47,5 @@ jobs:
       run: |
         python -m pip install -U pip setuptools wheel
         python -m pip install .[test]
-        python -m unittest -v tests.suite
+        cd tests
+        python -m unittest -v

pyproject.toml

@@ -1,10 +1,10 @@
 [build-system]
 build-backend = "setuptools.build_meta"
-requires = ["setuptools"]
+requires = ["setuptools", "cython"]
 
 [project]
 name = "httptools"
-dynamic = ["version"]
+dynamic = ["version", "optional-dependencies"]
 classifiers = [
     "Intended Audience :: Developers",
     "Programming Language :: Python :: 3",

setup.py

@@ -1,5 +1,7 @@
 import sys
 
+from Cython.Build import cythonize
+
 vi = sys.version_info
 if vi < (3, 8):
     raise RuntimeError('httptools require Python 3.8 or greater')
@@ -15,26 +17,18 @@
 
 ROOT = pathlib.Path(__file__).parent
 
-CYTHON_DEPENDENCY = 'Cython>=0.29.24'
+CYTHON_DEPENDENCY = 'Cython>=3.1.0'
 
 
 class httptools_build_ext(build_ext):
     user_options = build_ext.user_options + [
-        ('cython-always', None,
-            'run cythonize() even if .c files are present'),
-        ('cython-annotate', None,
-            'Produce a colorized HTML version of the Cython source.'),
-        ('cython-directives=', None,
-            'Cythion compiler directives'),
         ('use-system-llhttp', None,
             'Use the system provided llhttp, instead of the bundled one'),
         ('use-system-http-parser', None,
             'Use the system provided http-parser, instead of the bundled one'),
     ]
 
     boolean_options = build_ext.boolean_options + [
-        'cython-always',
-        'cython-annotate',
         'use-system-llhttp',
         'use-system-http-parser',
     ]
@@ -49,9 +43,6 @@ def initialize_options(self):
         super().initialize_options()
         self.use_system_llhttp = False
         self.use_system_http_parser = False
-        self.cython_always = False
-        self.cython_annotate = None
-        self.cython_directives = None
 
     def finalize_options(self):
         # finalize_options() may be called multiple times on the
@@ -60,53 +51,6 @@ def finalize_options(self):
         if getattr(self, '_initialized', False):
             return
 
-        need_cythonize = self.cython_always
-        cfiles = {}
-
-        for extension in self.distribution.ext_modules:
-            for i, sfile in enumerate(extension.sources):
-                if sfile.endswith('.pyx'):
-                    prefix, ext = os.path.splitext(sfile)
-                    cfile = prefix + '.c'
-
-                    if os.path.exists(cfile) and not self.cython_always:
-                        extension.sources[i] = cfile
-                    else:
-                        if os.path.exists(cfile):
-                            cfiles[cfile] = os.path.getmtime(cfile)
-                        else:
-                            cfiles[cfile] = 0
-                        need_cythonize = True
-
-        if need_cythonize:
-            try:
-                import Cython
-            except ImportError:
-                raise RuntimeError(
-                    'please install Cython to compile httptools from source')
-
-            if Cython.__version__ < '0.29':
-                raise RuntimeError(
-                    'httptools requires Cython version 0.29 or greater')
-
-            from Cython.Build import cythonize
-
-            directives = {}
-            if self.cython_directives:
-                for directive in self.cython_directives.split(','):
-                    k, _, v = directive.partition('=')
-                    if v.lower() == 'false':
-                        v = False
-                    if v.lower() == 'true':
-                        v = True
-
-                    directives[k] = v
-
-            self.distribution.ext_modules[:] = cythonize(
-                self.distribution.ext_modules,
-                compiler_directives=directives,
-                annotate=self.cython_annotate)
-
         super().finalize_options()
 
         self._initialized = True
@@ -172,7 +116,7 @@ def build_extensions(self):
     cmdclass={
         'build_ext': httptools_build_ext,
     },
-    ext_modules=[
+    ext_modules=cythonize([
         Extension(
             "httptools.parser.parser",
             sources=[
@@ -187,7 +131,7 @@ def build_extensions(self):
             ],
             extra_compile_args=CFLAGS,
         ),
-    ],
+    ]),
     include_package_data=True,
     exclude_package_data={"": ["*.c", "*.h"]},
     test_suite='tests.suite',