Fix create_connection when sock and ssl args are passed

Author: 1st1

tests/test_tcp.py

@@ -935,6 +935,27 @@ async def client(addr):
 
             writer.close()
 
+        async def client_sock(addr):
+            sock = socket.socket()
+            sock.connect(addr)
+            reader, writer = await asyncio.open_connection(
+                sock=sock,
+                ssl=client_sslctx,
+                server_hostname='',
+                loop=self.loop)
+
+            writer.write(A_DATA)
+            self.assertEqual(await reader.readexactly(2), b'OK')
+
+            writer.write(B_DATA)
+            self.assertEqual(await reader.readexactly(4), b'SPAM')
+
+            nonlocal CNT
+            CNT += 1
+
+            writer.close()
+            sock.close()
+
         def run(coro):
             nonlocal CNT
             CNT = 0
@@ -956,6 +977,9 @@ def run(coro):
         with self._silence_eof_received_warning():
             run(client)
 
+        with self._silence_eof_received_warning():
+            run(client_sock)
+
 
 class Test_UV_TCPSSL(_TestSSL, tb.UVTestCase):
 

uvloop/loop.pyx

@@ -1479,7 +1479,6 @@ cdef class Loop:
                     'host and port was not specified and no sock specified')
 
             waiter = self._new_future()
-            protocol = protocol_factory()
             tr = TCPTransport.new(self, protocol, None, waiter)
             try:
                 # libuv will make socket non-blocking