Skip to content

Commit 0843ddd

Browse files
committed
Only set TCP_NODELAY for TCPTransport (not TCPServer)
1 parent 016a024 commit 0843ddd

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

uvloop/handles/tcp.pxd

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
cdef class TCPServer(UVStreamServer):
22
cdef bind(self, system.sockaddr* addr, unsigned int flags=*)
3-
cdef _set_nodelay(self)
43

54
@staticmethod
65
cdef TCPServer new(Loop loop, object protocol_factory, Server server,

uvloop/handles/tcp.pyx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,6 @@ cdef class TCPServer(UVStreamServer):
6666
__tcp_init_uv_handle(<UVStream>handle, loop, flags)
6767
return handle
6868

69-
cdef _set_nodelay(self):
70-
cdef int err
71-
self._ensure_alive()
72-
err = uv.uv_tcp_nodelay(<uv.uv_tcp_t*>self._handle, 1);
73-
if err < 0:
74-
raise convert_error(err)
75-
7669
cdef _new_socket(self):
7770
return __tcp_get_socket(<UVSocketHandle>self)
7871

@@ -84,7 +77,6 @@ cdef class TCPServer(UVStreamServer):
8477
self._fatal_error(exc, True)
8578
else:
8679
self._mark_as_open()
87-
self._set_nodelay()
8880

8981
cdef bind(self, system.sockaddr* addr, unsigned int flags=0):
9082
self._ensure_alive()
@@ -94,7 +86,6 @@ cdef class TCPServer(UVStreamServer):
9486
self._fatal_error(exc, True)
9587
else:
9688
self._mark_as_open()
97-
self._set_nodelay()
9889

9990
cdef UVStream _make_new_transport(self, object protocol, object waiter):
10091
cdef TCPTransport tr

0 commit comments

Comments
 (0)