Fix loop.create_server() to error on non-int backlog argument

Author: 1st1

tests/test_tcp.py

@@ -498,6 +498,19 @@ async def start_server():
 
 class Test_UV_TCP(_TestTCP, tb.UVTestCase):
 
+    def test_create_server_float_backlog(self):
+        # asyncio spits out a warning we cannot suppress
+
+        async def runner(bl):
+            await self.loop.create_server(
+                asyncio.Protocol,
+                None, 0, backlog=bl)
+
+        for bl in (1.1, '1'):
+            with self.subTest(backlog=bl):
+                with self.assertRaisesRegex(TypeError, 'integer'):
+                    self.loop.run_until_complete(runner(bl))
+
     def test_many_small_writes(self):
         N = 10000
         TOTAL = 0

uvloop/handles/streamserver.pxd

@@ -12,7 +12,7 @@ cdef class UVStreamServer(UVSocketHandle):
 
     cdef inline _mark_as_open(self)
 
-    cdef inline listen(self, int backlog)
+    cdef inline listen(self, backlog)
     cdef inline _on_listen(self)
 
     cdef UVStream _make_new_transport(self, object protocol, object waiter)

uvloop/handles/streamserver.pyx

@@ -20,10 +20,15 @@ cdef class UVStreamServer(UVSocketHandle):
         self.protocol_factory = protocol_factory
         self._server = server
 
-    cdef inline listen(self, int backlog):
+    cdef inline listen(self, backlog):
         cdef int err
         self._ensure_alive()
 
+        if not isinstance(backlog, int):
+            # Don't allow floats
+            raise TypeError('integer argument expected, got {}'.format(
+                type(backlog).__name__))
+
         if self.protocol_factory is None:
             raise RuntimeError('unable to listen(); no protocol_factory')
 

uvloop/loop.pyx

@@ -1127,7 +1127,7 @@ cdef class Loop:
                             int family=uv.AF_UNSPEC,
                             int flags=uv.AI_PASSIVE,
                             sock=None,
-                            int backlog=100,
+                            backlog=100,
                             ssl=None,
                             reuse_address=None,  # ignored, libuv sets it
                             reuse_port=None):
@@ -1227,9 +1227,13 @@ cdef class Loop:
                         except OSError as err:
                             pyaddr = __convert_sockaddr_to_pyaddr(
                                 <system.sockaddr*>addrinfo.ai_addr)
+                            tcp._close()
                             raise OSError(err.errno, 'error while attempting '
                                           'to bind on address %r: %s'
                                           % (pyaddr, err.strerror.lower()))
+                        except:
+                            tcp._close()
+                            raise
 
                         server._add_server(tcp)
 
@@ -1249,11 +1253,12 @@ cdef class Loop:
                 tcp.open(fileno)
                 tcp._attach_fileobj(sock)
                 tcp.listen(backlog)
-                server._add_server(tcp)
             except:
                 tcp._close()
                 raise
 
+            server._add_server(tcp)
+
         return server
 
     async def create_connection(self, protocol_factory, host=None, port=None, *,