Make sure connection_lost is called when connection_made is errored out

Author: 1st1

tests/test_tcp.py

@@ -515,6 +515,7 @@ def test_tcp_handle_exception_in_connection_made(self):
         self.loop.set_exception_handler(lambda *args: None)
 
         fut = asyncio.Future(loop=self.loop)
+        connection_lost_called = asyncio.Future(loop=self.loop)
 
         async def server(reader, writer):
             try:
@@ -526,6 +527,9 @@ class Proto(asyncio.Protocol):
             def connection_made(self, tr):
                 1 / 0
 
+            def connection_lost(self, exc):
+                connection_lost_called.set_result(exc)
+
         srv = self.loop.run_until_complete(asyncio.start_server(
             server,
             '127.0.0.1', 0,
@@ -545,6 +549,9 @@ async def runner():
         self.loop.run_until_complete(srv.wait_closed())
         self.loop.run_until_complete(fut)
 
+        self.assertIsNone(
+            self.loop.run_until_complete(connection_lost_called))
+
 
 class Test_UV_TCP(_TestTCP, tb.UVTestCase):
 

uvloop/handles/basetransport.pyx

@@ -128,14 +128,17 @@ cdef class UVBaseTransport(UVSocketHandle):
 
         _loop_ready_len = self._loop._ready_len
 
+        # Set _protocol_connected to 1 before calling "connection_made":
+        # if transport is aborted or closed, "connection_lost" will
+        # still be scheduled.
+        self._protocol_connected = 1
+
         try:
             self._protocol.connection_made(self)
         except:
             self._wakeup_waiter()
             raise
 
-        self._protocol_connected = 1
-
         if self._closing:
             # This might happen when "transport.abort()" is called
             # from "Protocol.connection_made".