Skip to content

Commit 37bf83e

Browse files
committed
subprocess: Add an XXX comment about some blocking code in process handle
1 parent 7cb4451 commit 37bf83e

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

uvloop/handles/process.pyx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,9 @@ cdef class UVProcess(UVHandle):
9393
if preexec_fn is not None:
9494
errpipe_data = bytearray()
9595
while True:
96+
# XXX: This is a blocking code that has to be
97+
# rewritten (using loop.connect_read_pipe() or
98+
# otherwise.)
9699
part = os_read(self._errpipe_read, 50000)
97100
errpipe_data += part
98101
if not part or len(errpipe_data) > 50000:

0 commit comments

Comments
 (0)