Stop using malloc for UVRequests

Author: 1st1

uvloop/dns.pyx

@@ -249,6 +249,7 @@ cdef class AddrInfoRequest(UVRequest):
     cdef:
         system.addrinfo hints
         object callback
+        uv.uv_getaddrinfo_t _req_data
 
     def __cinit__(self, Loop loop,
                   bytes host, bytes port,
@@ -283,12 +284,7 @@ cdef class AddrInfoRequest(UVRequest):
         self.hints.ai_socktype = type
         self.hints.ai_protocol = proto
 
-        self.request = <uv.uv_req_t*> PyMem_RawMalloc(
-            sizeof(uv.uv_getaddrinfo_t))
-        if self.request is NULL:
-            self.on_done()
-            raise MemoryError()
-
+        self.request = <uv.uv_req_t*> &self._req_data
         self.callback = callback
         self.request.data = <void*>self
 
@@ -307,14 +303,10 @@ cdef class AddrInfoRequest(UVRequest):
 cdef class NameInfoRequest(UVRequest):
     cdef:
         object callback
+        uv.uv_getnameinfo_t _req_data
 
     def __cinit__(self, Loop loop, callback):
-        self.request = <uv.uv_req_t*> PyMem_RawMalloc(
-            sizeof(uv.uv_getnameinfo_t))
-        if self.request is NULL:
-            self.on_done()
-            raise MemoryError()
-
+        self.request = <uv.uv_req_t*> &self._req_data
         self.callback = callback
         self.request.data = <void*>self
 

uvloop/handles/pipe.pyx

@@ -176,12 +176,10 @@ cdef class WriteUnixTransport(UVStream):
 cdef class _PipeConnectRequest(UVRequest):
     cdef:
         UnixTransport transport
+        uv.uv_connect_t _req_data
 
     def __cinit__(self, loop, transport):
-        self.request = <uv.uv_req_t*> PyMem_RawMalloc(sizeof(uv.uv_connect_t))
-        if self.request is NULL:
-            self.on_done()
-            raise MemoryError()
+        self.request = <uv.uv_req_t*> &self._req_data
         self.request.data = <void*>self
         self.transport = transport
 

uvloop/handles/tcp.pyx

@@ -179,12 +179,10 @@ cdef class TCPTransport(UVStream):
 cdef class _TCPConnectRequest(UVRequest):
     cdef:
         TCPTransport transport
+        uv.uv_connect_t _req_data
 
     def __cinit__(self, loop, transport):
-        self.request = <uv.uv_req_t*> PyMem_RawMalloc(sizeof(uv.uv_connect_t))
-        if self.request is NULL:
-            self.on_done()
-            raise MemoryError()
+        self.request = <uv.uv_req_t*>&self._req_data
         self.request.data = <void*>self
         self.transport = transport
 

uvloop/request.pyx

@@ -13,15 +13,6 @@ cdef class UVRequest:
         self.done = 0
         Py_INCREF(self)
 
-    def __dealloc__(self):
-        if self.request is not NULL:
-            if self.done == 0:
-                raise RuntimeError(
-                    'Unable to deallocate request for {!r} (not done)'
-                    .format(self))
-            PyMem_RawFree(self.request)
-            self.request = NULL
-
     cdef on_done(self):
         self.done = 1
         Py_DECREF(self)