tests: Support 3.8

Author: 1st1

tests/test_base.py

@@ -347,19 +347,16 @@ def test_run_until_complete_loop_orphan_future_close_loop(self):
         if self.implementation == 'asyncio' and sys.version_info < (3, 6, 2):
             raise unittest.SkipTest('unfixed asyncio')
 
-        class ShowStopper(BaseException):
-            pass
-
         async def foo(delay):
             await asyncio.sleep(delay)
 
         def throw():
-            raise ShowStopper
+            raise KeyboardInterrupt
 
         self.loop.call_soon(throw)
         try:
             self.loop.run_until_complete(foo(0.1))
-        except ShowStopper:
+        except KeyboardInterrupt:
             pass
 
         # This call fails if run_until_complete does not clean up

tests/test_executors.py

@@ -1,5 +1,7 @@
 import asyncio
 import concurrent.futures
+import multiprocessing
+import unittest
 
 from uvloop import _testbase as tb
 
@@ -26,6 +28,9 @@ async def run():
         fib10 = [fib(i) for i in range(10)]
         self.loop.run_until_complete(run())
 
+    @unittest.skipIf(
+        multiprocessing.get_start_method(False) == 'spawn',
+        'no need to test on macOS where spawn is used instead of fork')
     def test_executors_process_pool_01(self):
         self.run_pool_test(concurrent.futures.ProcessPoolExecutor)
 

tests/test_regr1.py

@@ -3,6 +3,9 @@
 import multiprocessing
 import signal
 import threading
+import unittest
+
+import uvloop
 
 from uvloop import _testbase as tb
 
@@ -32,35 +35,40 @@ class FailedTestError(BaseException):
     pass
 
 
+def run_server(quin, qout):
+    server_loop = None
+
+    def server_thread():
+        nonlocal server_loop
+        loop = server_loop = uvloop.new_event_loop()
+        asyncio.set_event_loop(loop)
+        coro = loop.create_server(EchoServerProtocol, '127.0.0.1', 0)
+        server = loop.run_until_complete(coro)
+        addr = server.sockets[0].getsockname()
+        qout.put(addr)
+        loop.run_forever()
+        server.close()
+        loop.run_until_complete(server.wait_closed())
+        try:
+            loop.close()
+        except Exception as exc:
+            print(exc)
+        qout.put('stopped')
+
+    thread = threading.Thread(target=server_thread, daemon=True)
+    thread.start()
+
+    quin.get()
+    server_loop.call_soon_threadsafe(server_loop.stop)
+    thread.join(1)
+
+
 class TestIssue39Regr(tb.UVTestCase):
     """See https://github.com/MagicStack/uvloop/issues/39 for details.
 
     Original code to reproduce the bug is by Jim Fulton.
     """
 
-    def run_server(self, quin, qout):
-        def server_thread():
-            loop = self.server_loop = self.new_loop()
-            coro = loop.create_server(EchoServerProtocol, '127.0.0.1', 0)
-            server = loop.run_until_complete(coro)
-            addr = server.sockets[0].getsockname()
-            qout.put(addr)
-            loop.run_forever()
-            server.close()
-            loop.run_until_complete(server.wait_closed())
-            try:
-                loop.close()
-            except Exception as exc:
-                print(exc)
-            qout.put('stopped')
-
-        thread = threading.Thread(target=server_thread, daemon=True)
-        thread.start()
-
-        quin.get()
-        self.server_loop.call_soon_threadsafe(self.server_loop.stop)
-        thread.join(1)
-
     def on_alarm(self, sig, fr):
         if self.running:
             raise FailedTestError
@@ -72,19 +80,20 @@ def run_test(self):
                     if threaded:
                         qin, qout = queue.Queue(), queue.Queue()
                         threading.Thread(
-                            target=self.run_server,
+                            target=run_server,
                             args=(qin, qout),
                             daemon=True).start()
                     else:
                         qin = multiprocessing.Queue()
                         qout = multiprocessing.Queue()
                         multiprocessing.Process(
-                            target=self.run_server,
+                            target=run_server,
                             args=(qin, qout),
                             daemon=True).start()
 
                     addr = qout.get()
                     loop = self.new_loop()
+                    asyncio.set_event_loop(loop)
                     loop.create_task(
                         loop.create_connection(
                             lambda: EchoClientProtocol(loop),
@@ -96,6 +105,9 @@ def run_test(self):
         finally:
             loop.close()
 
+    @unittest.skipIf(
+        multiprocessing.get_start_method(False) == 'spawn',
+        'no need to test on macOS where spawn is used instead of fork')
     def test_issue39_regression(self):
         signal.signal(signal.SIGALRM, self.on_alarm)
         signal.alarm(5)

tests/test_signals.py

@@ -3,6 +3,7 @@
 import subprocess
 import sys
 import time
+import unittest
 import uvloop
 
 from uvloop import _testbase as tb
@@ -280,6 +281,9 @@ def test_signals_no_SIGCHLD(self):
 
             self.loop.add_signal_handler(signal.SIGCHLD, lambda *a: None)
 
+    @unittest.skipIf(sys.version_info[:3] >= (3, 8, 0),
+                     'in 3.8 a ThreadedChildWatcher is used '
+                     '(does not rely on SIGCHLD)')
     def test_asyncio_add_watcher_SIGCHLD_nop(self):
         asyncio.set_event_loop_policy(asyncio.DefaultEventLoopPolicy())
         asyncio.get_event_loop_policy().get_child_watcher()

tests/test_sockets.py

@@ -25,6 +25,10 @@ def test_socket_connect_recv_send(self):
             # See https://github.com/python/asyncio/pull/366 for details.
             raise unittest.SkipTest()
 
+        if sys.version_info[:3] >= (3, 8, 0):
+            # @asyncio.coroutine is deprecated in 3.8
+            raise unittest.SkipTest()
+
         def srv_gen(sock):
             sock.send(b'helo')
             data = sock.recv_all(4 * _SIZE)
@@ -190,6 +194,11 @@ def test_socket_sync_remove_and_immediately_close(self):
             self.loop.run_until_complete(asyncio.sleep(0.01))
 
     def test_sock_cancel_add_reader_race(self):
+        if self.is_asyncio_loop() and sys.version_info[:3] == (3, 8, 0):
+            # asyncio 3.8.0 seems to have a regression;
+            # tracked in https://bugs.python.org/issue30064
+            raise unittest.SkipTest()
+
         srv_sock_conn = None
 
         async def server():
@@ -236,6 +245,11 @@ async def send_server_data():
         self.loop.run_until_complete(server())
 
     def test_sock_send_before_cancel(self):
+        if self.is_asyncio_loop() and sys.version_info[:3] == (3, 8, 0):
+            # asyncio 3.8.0 seems to have a regression;
+            # tracked in https://bugs.python.org/issue30064
+            raise unittest.SkipTest()
+
         srv_sock_conn = None
 
         async def server():