Fix create_server to bind correctly to ipv6 addresses on Linux

Author: 1st1

tests/test_tcp.py

@@ -177,6 +177,17 @@ def test_create_server_4(self):
                 self.loop.run_until_complete(
                     self.loop.create_server(object, *addr))
 
+    def test_create_server_5(self):
+        port = tb.find_free_port()
+
+        async def runner():
+            srv = await self.loop.create_server(
+                asyncio.Protocol,
+                None, port)
+            srv.close()
+
+        self.loop.run_until_complete(runner())
+
     def test_create_connection_1(self):
         CNT = 0
         TOTAL_CNT = 100

uvloop/_testbase.py

@@ -85,6 +85,19 @@ def filter(self, record):
         logger.removeFilter(filter)
 
 
+def find_free_port(start_from=50000):
+    for port in range(start_from, start_from + 500):
+        sock = socket.socket()
+        with sock:
+            try:
+                sock.bind(('', port))
+            except socket.error:
+                continue
+            else:
+                return port
+    raise RuntimeError('could not find a free port')
+
+
 class SSLTestCase:
 
     ONLYCERT = _cert_fullname('ssl_cert.pem')

uvloop/includes/stdlib.pxi

@@ -42,9 +42,7 @@ cdef ft_partial = functools.partial
 
 cdef iter_chain = itertools.chain
 
-cdef int has_AF_INET6 = hasattr(socket, 'AF_INET6')
 cdef int has_SO_REUSEPORT = hasattr(socket, 'SO_REUSEPORT')
-cdef int has_IPPROTO_IPV6 = hasattr(socket, 'IPPROTO_IPV6')
 cdef int SO_REUSEPORT = getattr(socket, 'SO_REUSEPORT', 0)
 
 cdef socket_gaierror = socket.gaierror

uvloop/includes/uv.pxd

@@ -11,6 +11,8 @@ cdef extern from "includes/compat.h":
 
 
 cdef extern from "uv.h" nogil:
+    cdef int UV_TCP_IPV6ONLY
+
     cdef int UV_EACCES
     cdef int UV_EAGAIN
     cdef int UV_EALREADY
@@ -57,7 +59,6 @@ cdef extern from "uv.h" nogil:
     cdef int AI_PASSIVE
     cdef int AI_NUMERICHOST
     cdef int INET6_ADDRSTRLEN
-    cdef int IPV6_V6ONLY
     cdef int IPPROTO_IPV6
     cdef int SOCK_STREAM
     cdef int SOCK_DGRAM

uvloop/loop.pyx

@@ -1121,6 +1121,7 @@ cdef class Loop:
             TCPServer tcp
             system.addrinfo *addrinfo
             Server server = Server(self)
+            int bind_flags
 
         if ssl is not None and not isinstance(ssl, ssl_SSLContext):
             raise TypeError('ssl argument must be an SSLContext or None')
@@ -1163,8 +1164,13 @@ cdef class Loop:
                         if reuse_port:
                             self._sock_set_reuseport(tcp._fileno())
 
+                        if addrinfo.ai_family == uv.AF_INET6:
+                            bind_flags = uv.UV_TCP_IPV6ONLY
+                        else:
+                            bind_flags = 0
+
                         try:
-                            tcp.bind(addrinfo.ai_addr)
+                            tcp.bind(addrinfo.ai_addr, bind_flags)
                             tcp.listen(backlog)
                         except OSError as err:
                             pyaddr = __convert_sockaddr_to_pyaddr(