Enable TCP_NODELAY for all TCP transports

Author: 1st1

tests/test_tcp.py

@@ -72,6 +72,12 @@ async def handle_client(reader, writer):
             writer.write(bytearray(b'A'))
             writer.write(memoryview(b'M'))
 
+            if self.implementation == 'uvloop':
+                tr = writer.transport
+                sock = tr.get_extra_info('socket')
+                self.assertTrue(
+                    sock.getsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY))
+
             await writer.drain()
             writer.close()
 
@@ -340,6 +346,12 @@ async def client(addr):
             writer.write(b'BBBB')
             self.assertEqual(await reader.readexactly(4), b'SPAM')
 
+            if self.implementation == 'uvloop':
+                tr = writer.transport
+                sock = tr.get_extra_info('socket')
+                self.assertTrue(
+                    sock.getsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY))
+
             nonlocal CNT
             CNT += 1
 

uvloop/handles/tcp.pxd

@@ -1,5 +1,6 @@
 cdef class TCPServer(UVStreamServer):
     cdef bind(self, system.sockaddr* addr, unsigned int flags=*)
+    cdef _set_nodelay(self)
 
     @staticmethod
     cdef TCPServer new(Loop loop, object protocol_factory, Server server,
@@ -15,6 +16,7 @@ cdef class TCPTransport(UVStream):
 
     cdef bind(self, system.sockaddr* addr, unsigned int flags=*)
     cdef connect(self, system.sockaddr* addr)
+    cdef _set_nodelay(self)
 
     @staticmethod
     cdef TCPTransport new(Loop loop, object protocol, Server server,

uvloop/handles/tcp.pyx

@@ -66,6 +66,13 @@ cdef class TCPServer(UVStreamServer):
         __tcp_init_uv_handle(<UVStream>handle, loop, flags)
         return handle
 
+    cdef _set_nodelay(self):
+        cdef int err
+        self._ensure_alive()
+        err = uv.uv_tcp_nodelay(<uv.uv_tcp_t*>self._handle, 1);
+        if err < 0:
+            raise convert_error(err)
+
     cdef _new_socket(self):
         return __tcp_get_socket(<UVSocketHandle>self)
 
@@ -77,6 +84,7 @@ cdef class TCPServer(UVStreamServer):
             self._fatal_error(exc, True)
         else:
             self._mark_as_open()
+            self._set_nodelay()
 
     cdef bind(self, system.sockaddr* addr, unsigned int flags=0):
         self._ensure_alive()
@@ -86,6 +94,7 @@ cdef class TCPServer(UVStreamServer):
             self._fatal_error(exc, True)
         else:
             self._mark_as_open()
+            self._set_nodelay()
 
     cdef UVStream _make_new_transport(self, object protocol, object waiter):
         cdef TCPTransport tr
@@ -106,8 +115,16 @@ cdef class TCPTransport(UVStream):
         __tcp_init_uv_handle(<UVStream>handle, loop, uv.AF_UNSPEC)
         handle.__peername_set = 0
         handle.__sockname_set = 0
+        handle._set_nodelay()
         return handle
 
+    cdef _set_nodelay(self):
+        cdef int err
+        self._ensure_alive()
+        err = uv.uv_tcp_nodelay(<uv.uv_tcp_t*>self._handle, 1);
+        if err < 0:
+            raise convert_error(err)
+
     cdef _call_connection_made(self):
         # asyncio saves peername & sockname when transports are instantiated,
         # so that they're accessible even after the transport is closed.