Extension of TxDAQController for arbitrary waveforms #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sequence should now set all unused components to 0, forward calibration is now applied at the top level in setupTx
construction of ControlSequence
added amplitude and phase and implemented loading from h5 files
* allow for different stepspermm per axis * allow for motor current version differences
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #68 +/- ##
=========================================
- Coverage 8.60% 7.94% -0.67%
=========================================
Files 108 110 +2
Lines 8284 9326 +1042
=========================================
+ Hits 713 741 +28
- Misses 7571 8585 +1014 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a control scheme for arbitrary waveforms as presented here: https://doi.org/10.18416/IJMPI.2023.2303088 (only linear case). It is not 100% stable yet, but seems to work mostly fine. This needs the changes made to the TransferFunction type in MagneticParticleImaging/MPIFiles.jl#54
I will document the changes in this PR:
Changes
WIP