Refactoring Registry class

Author: MahBoiDeveloper

src/Logger.cpp

@@ -167,7 +167,7 @@ using namespace std;
 #pragma region Support methods
     const string Logger::GetWindowsBit() const
     {
-        if (Windows::Registry::GetWindowsBit() == Windows::Registry::WindowsBit::Win32)
+        if (Windows::Registry::GetWindowsBit() == Windows::Registry::Arch::Win32)
             return "32-bit";
         else
             return "64-bit";

src/Windows/Registry.cpp

@@ -10,15 +10,15 @@ using namespace std;
 
 namespace Windows
 {
-    Registry::WindowsBit Registry::GetWindowsBit()
+    Registry::Arch Registry::GetWindowsBit()
     {
         HKEY rKey;
-        WindowsBit windowsBit;
+        Arch windowsBit;
 
         if (RegOpenKeyExA(HKEY_LOCAL_MACHINE, _T("SOFTWARE\\WOW6432Node"), 0, KEY_QUERY_VALUE, &rKey) == ERROR_SUCCESS)
-            windowsBit = WindowsBit::Win64;
+            windowsBit = Arch::Win64;
         else
-            windowsBit = WindowsBit::Win32;
+            windowsBit = Arch::Win32;
 
         RegCloseKey(rKey);
 
@@ -103,8 +103,8 @@ namespace Windows
 
     QString Registry::ToQString(Games game) { return QString::fromStdString(Registry::ToString(game)); }
 
-    bool Registry::IsWindow64bit() { return GetWindowsBit() == WindowsBit::Win64; }
-    bool Registry::IsWindow32bit() { return GetWindowsBit() == WindowsBit::Win32; }
+    bool Registry::IsWindow64bit() { return GetWindowsBit() == Arch::Win64; }
+    bool Registry::IsWindow32bit() { return GetWindowsBit() == Arch::Win32; }
 
 #pragma region Logger methods
         string Registry::GetCurrentUserLanguage()

src/Windows/Registry.hpp

@@ -8,7 +8,7 @@ namespace Windows
     class Registry final
     {
     public: // Data
-        enum class WindowsBit
+        enum class Arch
         {
             Win32,
             Win64
@@ -27,12 +27,12 @@ namespace Windows
         };
 
         /// @brief Paths in Window's registry to the C&C: Generals and C&C: Generals — Zero Hour
-        inline static const std::map<Games, std::map<WindowsBit, std::wstring>> PATHS_TO_GAMES =
+        inline static const std::map<Games, std::map<Arch, std::wstring>> PATHS_TO_GAMES =
         {
-            {Games::Generals,      {{WindowsBit::Win32, L"SOFTWARE\\Electronic Arts\\EA Games\\Generals"},
-                                    {WindowsBit::Win64, L"SOFTWARE\\WOW6432Node\\Electronic Arts\\EA Games\\Generals"}}},
-            {Games::GeneralsZeroHour, {{WindowsBit::Win32, L"SOFTWARE\\Electronic Arts\\EA Games\\Command and Conquer Generals Zero Hour"},
-                                       {WindowsBit::Win64, L"SOFTWARE\\WOW6432Node\\Electronic Arts\\EA Games\\Command and Conquer Generals Zero Hour"}}},
+            {Games::Generals,      {{Arch::Win32, L"SOFTWARE\\Electronic Arts\\EA Games\\Generals"},
+                                    {Arch::Win64, L"SOFTWARE\\WOW6432Node\\Electronic Arts\\EA Games\\Generals"}}},
+            {Games::GeneralsZeroHour, {{Arch::Win32, L"SOFTWARE\\Electronic Arts\\EA Games\\Command and Conquer Generals Zero Hour"},
+                                       {Arch::Win64, L"SOFTWARE\\WOW6432Node\\Electronic Arts\\EA Games\\Command and Conquer Generals Zero Hour"}}},
         };
 
     public: // Methods
@@ -43,7 +43,7 @@ namespace Windows
         /// @brief Returns equal string for enum class value. 
         static QString ToQString(Games game);
         /// @brief Returns actual Windows bit like a enum value.
-        static WindowsBit GetWindowsBit();
+        static Arch GetWindowsBit();
 
         /// @brief Returns REG_SZ string value from MS Windows registry.
         static std::string GetTextFromKeyA(RootFolder Folder, const char* pPathToFolder, const char* pKeyName);