Skip to content

Commit a3907c1

Browse files
committed
Update ArnaTabView, ArnaTabItem and ArnaBanner
1 parent e6eca4d commit a3907c1

File tree

4 files changed

+37
-28
lines changed

4 files changed

+37
-28
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@
3737
- Add ArnaSlideTransition
3838
- Add ArnaFadeTransition
3939
- Update ArnaDivider
40+
- Update ArnaTabView
41+
- Update ArnaTabItem
42+
- Update ArnaBanner
4043

4144
## 1.0.5
4245

lib/src/base/banner.dart

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -134,28 +134,26 @@ class _ArnaBannerState extends State<ArnaBanner>
134134
final Widget banner = Semantics(
135135
container: true,
136136
liveRegion: true,
137-
child: Column(
138-
mainAxisSize: MainAxisSize.min,
139-
children: <Widget>[
140-
ColoredBox(
141-
color: ArnaColors.headerColor.resolveFrom(context),
142-
child: ArnaListTile(
143-
leading: Icon(
144-
icon,
145-
color: ArnaDynamicColor.resolve(accent, context),
146-
),
147-
title: widget.title,
148-
subtitle: widget.subtitle,
149-
trailing: widget.actions != null
150-
? Row(
151-
mainAxisSize: MainAxisSize.min,
152-
children: widget.actions!,
153-
)
154-
: null,
137+
child: Padding(
138+
padding: Styles.normal,
139+
child: ClipRRect(
140+
borderRadius: Styles.borderRadius,
141+
child: ArnaListTile(
142+
leading: Icon(
143+
icon,
144+
color: ArnaDynamicColor.resolve(accent, context),
155145
),
146+
title: widget.title,
147+
subtitle: widget.subtitle,
148+
trailing: widget.actions != null
149+
? Row(
150+
mainAxisSize: MainAxisSize.min,
151+
children: widget.actions!,
152+
)
153+
: null,
154+
showBackground: false,
156155
),
157-
const ArnaDivider(),
158-
],
156+
),
159157
),
160158
);
161159

lib/src/base/tab_item.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,12 @@ class ArnaTabItem extends StatelessWidget {
9090
? ArnaDynamicColor.applyOverlay(
9191
selected
9292
? ArnaColors.buttonColor.resolveFrom(context)
93-
: ArnaColors.sideColor.resolveFrom(context),
93+
: ArnaColors.backgroundColor
94+
.resolveFrom(context),
9495
)
9596
: selected
9697
? ArnaColors.buttonColor
97-
: ArnaColors.sideColor,
98+
: ArnaColors.backgroundColor,
9899
context,
99100
),
100101
),

lib/src/base/tab_view.dart

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,18 @@ class _ArnaTabViewState extends State<ArnaTabView> with RestorationMixin {
241241
children: <Widget>[
242242
Container(
243243
height: Styles.tabBarHeight,
244-
color: ArnaColors.sideColor.resolveFrom(context),
244+
decoration: BoxDecoration(
245+
border: Border(
246+
top: BorderSide(
247+
color: ArnaColors.borderColor.resolveFrom(context),
248+
width: 0.0,
249+
),
250+
bottom: BorderSide(
251+
color: ArnaColors.borderColor.resolveFrom(context),
252+
width: 0.0,
253+
),
254+
),
255+
),
245256
child: Semantics(
246257
explicitChildNodes: true,
247258
child: Row(
@@ -289,12 +300,8 @@ class _ArnaTabViewState extends State<ArnaTabView> with RestorationMixin {
289300
),
290301
),
291302
),
292-
const Padding(
293-
padding: ArnaEdgeInsets.top(Styles.tabBarHeight),
294-
child: ArnaDivider(),
295-
),
296303
Padding(
297-
padding: const ArnaEdgeInsets.top(Styles.tabBarHeight + 1),
304+
padding: const ArnaEdgeInsets.top(Styles.tabBarHeight),
298305
child: FocusTraversalGroup(
299306
child: Builder(
300307
builder: (BuildContext context) {

0 commit comments

Comments
 (0)