Skip to content

Commit 0820f10

Browse files
authored
[hip] Don't join the status in dispatch_thread. (iree-org#19583)
If the status was an error status that we are passing in, then it will be passed back to us. It is incorrect to join it. Signed-off-by: Andrew Woloszyn <[email protected]>
1 parent cdf24b9 commit 0820f10

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

runtime/src/iree/hal/drivers/hip/dispatch_thread.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ static int iree_hal_hip_dispatch_thread_main(void* param) {
6262
iree_hal_hip_dispatch_queue_pop_front(&thread->queue, 1);
6363
iree_slim_mutex_unlock(&thread->mutex);
6464

65-
status = iree_status_join(status,
66-
dispatch.dispatch(dispatch.user_data, status));
65+
// The status passed will be joined and returned.
66+
status = dispatch.dispatch(dispatch.user_data, status);
6767
iree_slim_mutex_lock(&thread->mutex);
6868
if (!iree_status_is_ok(status)) {
6969
// We don't join here as the failure status was already

0 commit comments

Comments
 (0)