Skip to content

Commit 6f6e577

Browse files
authored
[ROCm] Fix typo in R9700 SKU definition. NFC. (iree-org#21247)
Reported by Jam.
1 parent af9f7c1 commit 6f6e577

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

compiler/plugins/target/ROCM/test/target_device_features.mlir

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
// RUN: --iree-hip-target=rx9070 %s | FileCheck %s --check-prefixes=GFX1201,RX9070
4040
//
4141
// RUN: iree-opt --pass-pipeline='builtin.module(iree-hal-assign-target-devices{targetDevices=hip},iree-hal-transformation-pipeline{serialize-executables=false})' \
42-
// RUN: --iree-hip-target=r9070 %s | FileCheck %s --check-prefixes=GFX1201,R9070
42+
// RUN: --iree-hip-target=r9700 %s | FileCheck %s --check-prefixes=GFX1201,R9700
4343

4444
// GFX942: target = #iree_gpu.target<arch = "gfx942",
4545
// GFX942-SAME: wgp = <compute = fp64|fp32|fp16|int64|int32|int16|int8, storage = b64|b32|b16|b8,
@@ -78,7 +78,7 @@
7878
//
7979
// RX9070XT: chip = <wgp_count = 32, sku = "rx9070xt">>
8080
// RX9070: chip = <wgp_count = 28, sku = "rx9070">>
81-
// R9070: chip = <wgp_count = 32, sku = "r9070">>
81+
// R9700: chip = <wgp_count = 32, sku = "r9700">>
8282

8383
stream.executable public @reduce_dispatch {
8484
stream.executable.export @reduce_dispatch workgroups(%arg0: index) -> (index, index, index) {

compiler/src/iree/compiler/Codegen/Dialect/GPU/TargetUtils/KnownTargets.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ std::optional<TargetDetails> getAMDGPUTargetDetails(StringRef target) {
407407

408408
// AMD RDNA4 architecture:
409409
// https://www.amd.com/en/newsroom/press-releases/2025-2-28-amd-unveils-next-generation-amd-rdna-4-architectu.html.
410-
static const ChipDetails r9070Chip = {64 / 2, "r9070"};
410+
static const ChipDetails r9700Chip = {64 / 2, "r9700"};
411411
static const ChipDetails rx9070xtChip = {64 / 2, "rx9070xt"};
412412
static const ChipDetails rx9070Chip = {56 / 2, "rx9070"};
413413
static const ChipDetails rx9060xtChip = {32 / 2, "rx9060xt"};
@@ -442,7 +442,7 @@ std::optional<TargetDetails> getAMDGPUTargetDetails(StringRef target) {
442442
// https://www.techpowerup.com/gpu-specs/radeon-rx-9070.c4250
443443
.Case("rx9070", TargetDetails{rdna4Wgp, &rx9070Chip})
444444
// https://www.techpowerup.com/gpu-specs/radeon-ai-pro-r9700.c4290
445-
.Case("r9070", TargetDetails{rdna4Wgp, &r9070Chip})
445+
.Case("r9700", TargetDetails{rdna4Wgp, &r9700Chip})
446446
// https://www.techpowerup.com/gpu-specs/radeon-rx-9060-xt-16-gb.c4293
447447
.Case("rx9060xt", TargetDetails{rdna4Wgp, &rx9060xtChip})
448448
// https://www.techpowerup.com/gpu-specs/radeon-rx-7900-xtx.c3941
@@ -484,7 +484,7 @@ StringRef normalizeAMDGPUTarget(StringRef target) {
484484
.Cases("mi300a", "mi300x", "mi308x", "mi325x", "gfx942")
485485
.Cases("mi250x", "mi250", "mi210", "cdna2", "gfx90a")
486486
.Cases("mi100", "cdna1", "gfx908")
487-
.Cases("rx9070xt", "rx9070", "r9070", "gfx1201")
487+
.Cases("rx9070xt", "rx9070", "r9700", "gfx1201")
488488
.Case("rx9060xt", "gfx1200")
489489
.Cases("rx7900xtx", "rx7900xt", "w7900", "w7800", "gfx1100")
490490
.Cases("rx7800xt", "rx7700xt", "v710", "w7700", "gfx1101")

docs/website/docs/guides/deployment-configurations/gpu-rocm.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ architectures:
204204
| AMD RX 9060XT | `rx9060xt` | `gfx1200` | `rdna4` |
205205
| AMD RX 9070 | `rx9070` | `gfx1201` | `rdna4` |
206206
| AMD RX 9070XT | `rx9070xt` | `gfx1201` | `rdna4` |
207-
| AMD AI PRO R9070 | `r9070` | `gfx1201` | `rdna4` |
207+
| AMD AI PRO R9700 | `r9700` | `gfx1201` | `rdna4` |
208208

209209
For a more comprehensive list of prior GPU generations, you can refer to the
210210
[LLVM AMDGPU backend](https://llvm.org/docs/AMDGPUUsage.html#processors).

0 commit comments

Comments
 (0)