-
Notifications
You must be signed in to change notification settings - Fork 50
feat: Change instance methods to static methods #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
sorry, I have missed your PR
do we have plans to return it back? the main reason why it was added because we had a lot of calculations for the same hand during the real game loop it is not clear should cache to be the part of the lib or the part of the code that is using lib, but probably having it in lib helps |
|
@Nihisil I tried introducing |
|
As a side note, I'm aware that the current divide approach is not very efficient. For reference, I've collected four more efficient algorithms in a repository here: https://github.com/Apricot-S/block-decomposition. This might be useful background material for future improvements. |
…nternal state property
59b12db to
6cc4fad
Compare
|
I've reverted For now, I plan to wrap up this PR in its current form. |
#74
The cache inHandDividerhas been removed for now.