Fix a bug with yakuhai strategy and tempai

Author: Nihisil

project/game/ai/first_version/strategies/yakuhai.py

@@ -101,7 +101,11 @@ def determine_what_to_discard(self, discard_options, hand, open_melds):
         tiles_34 = TilesConverter.to_34_array(hand)
 
         valued_pairs = [x for x in self.player.valued_honors if tiles_34[x] == 2]
+
+        # closed pon sets
         valued_pons = [x for x in self.player.valued_honors if tiles_34[x] == 3]
+        # open pon sets
+        valued_pons += [x for x in open_melds if x.type == Meld.PON and x.tiles[0] // 4 in self.player.valued_honors]
 
         acceptable_options = []
         for item in discard_options:

project/game/ai/first_version/tests/strategies/tests_yakuhai.py

@@ -524,3 +524,22 @@ def test_atodzuke_choose_hidden_syanpon(self):
         player.draw_tile(self._string_to_136_tile(man='6'))
         discarded_tile = player.discard_tile()
         self.assertNotEqual(self._to_string([discarded_tile]), '6m')
+
+    def test_tempai_with_open_yakuhai_meld_and_yakuhai_pair_in_the_hand(self):
+        """
+        there was a bug where bot didn't handle tempai properly
+        with opened yakuhai pon and pair in the hand
+        56m555p6678s55z + [777z]
+        """
+        table = Table()
+        player = table.player
+
+        tiles = self._string_to_136_array(man='56', pin='555', sou='667', honors='55777')
+        player.init_hand(tiles)
+        player.add_called_meld(self._make_meld(Meld.PON, honors='777'))
+        player.draw_tile(self._string_to_136_tile(sou='8'))
+
+        player.ai.current_strategy = YakuhaiStrategy(BaseStrategy.YAKUHAI, player)
+
+        discarded_tile = player.discard_tile()
+        self.assertEqual(self._to_string([discarded_tile]), '6s')