Make Altcha captcha texts translatable (#591)

fballiano · web-flow · commit 5c650ccc6e00 · 2026-02-26T10:25:00.000Z
* Make Altcha captcha texts translatable

Add the Altcha i18n all language bundle so the widget automatically
displays translated strings based on the store locale (detected from
the html lang attribute). Also make the custom Verifying loader
dialog text translatable via PHP translation system.

* Use dynamic locale for html lang attribute on admin standalone pages
diff --git a/app/design/adminhtml/default/default/template/captcha/captcha.phtml b/app/design/adminhtml/default/default/template/captcha/captcha.phtml
@@ -18,7 +18,8 @@ if (!$helper->isEnabled()) return '';
         MahoCaptcha.setup({
             frontendSelectors: '#loginForm',
             widgetAttributes: <?= $helper->getWidgetAttributes()->toJson() ?>,
-            loadingImageUrl: '<?= $this->getSkinUrl('images/loading.svg') ?>'
+            loadingImageUrl: '<?= $this->getSkinUrl('images/loading.svg') ?>',
+            verifyingText: '<?= $this->jsQuoteEscape($helper->__('Verifying...')) ?>'
         });
     });
 </script>
diff --git a/app/design/adminhtml/default/default/template/forgotpassword.phtml b/app/design/adminhtml/default/default/template/forgotpassword.phtml
@@ -12,7 +12,7 @@
 /** @var Mage_Adminhtml_Block_Template $this */
 ?>
 <!DOCTYPE html>
-<html lang="en">
+<html lang="<?= substr(Mage::app()->getLocale()->getLocaleCode(), 0, 2) ?>">
 <head>
     <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
     <meta name="robots" content="noindex, nofollow" />
diff --git a/app/design/adminhtml/default/default/template/login.phtml b/app/design/adminhtml/default/default/template/login.phtml
@@ -12,7 +12,7 @@
 /** @var Mage_Adminhtml_Block_Template $this */
 ?>
 <!DOCTYPE html>
-<html lang="en">
+<html lang="<?= substr(Mage::app()->getLocale()->getLocaleCode(), 0, 2) ?>">
 <head>
     <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
     <meta name="robots" content="noindex, nofollow" />
diff --git a/app/design/adminhtml/default/default/template/resetforgottenpassword.phtml b/app/design/adminhtml/default/default/template/resetforgottenpassword.phtml
@@ -12,7 +12,7 @@
 /** @var Mage_Adminhtml_Block_Template $this */
 ?>
 <!DOCTYPE html>
-<html lang="en">
+<html lang="<?= substr(Mage::app()->getLocale()->getLocaleCode(), 0, 2) ?>">
 <head>
     <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
     <meta name="robots" content="noindex, nofollow" />
diff --git a/app/design/frontend/base/default/template/captcha/footer.phtml b/app/design/frontend/base/default/template/captcha/footer.phtml
@@ -18,7 +18,8 @@ if (!$helper->isEnabled()) return '';
         MahoCaptcha.setup({
             frontendSelectors: '<?= $helper->getFrontendSelectors() ?>',
             widgetAttributes: <?= $helper->getWidgetAttributes()->toJson() ?>,
-            loadingImageUrl: '<?= $this->getSkinUrl('images/loading.svg') ?>'
+            loadingImageUrl: '<?= $this->getSkinUrl('images/loading.svg') ?>',
+            verifyingText: '<?= $this->jsQuoteEscape($helper->__('Verifying...')) ?>'
         });
     });
 </script>
diff --git a/app/locale/en_US/Maho_Captcha.csv b/app/locale/en_US/Maho_Captcha.csv
@@ -6,3 +6,4 @@
 "Incorrect CAPTCHA.","Incorrect CAPTCHA."
 "Internal Error","Internal Error"
 "These CSS selectors are used to identify the forms for which captcha will be activated.<br />One selector per line.<br />To disable a selector, type // at the beginning of the line.","These CSS selectors are used to identify the forms for which captcha will be activated.<br />One selector per line.<br />To disable a selector, type // at the beginning of the line."
+"Verifying...","Verifying..."
diff --git a/public/js/altcha-i18n.min.js b/public/js/altcha-i18n.min.js
diff --git a/public/js/maho-captcha.js b/public/js/maho-captcha.js
