Fixed bulk attribute update toggleFieldEditMode crash (#620)

Author: fballiano

app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Action/Attribute/Tab/Attributes.php

@@ -85,7 +85,7 @@ protected function _getAdditionalElementHtml($element)
         $nameAttributeHtml = ($element->getExtType() === 'multiple') ? 'name="' . $element->getId() . '_checkbox"'
             : '';
         return '<span class="attribute-change-checkbox"><input type="checkbox" id="' . $element->getId()
-             . '-checkbox" ' . $nameAttributeHtml . ' onclick="toogleFieldEditMode(this, \'' . $element->getId()
+             . '-checkbox" ' . $nameAttributeHtml . ' onclick="toggleFieldEditMode(this, \'' . $element->getId()
              . '\')" /><label for="' . $element->getId() . '-checkbox">' . Mage::helper('catalog')->__('Change')
              . '</label></span>
                 <script type="text/javascript">initDisableFields(\'' . $element->getId() . '\')</script>';

public/js/mage/adminhtml/product.js

@@ -166,7 +166,6 @@ Product.Gallery = class {
         this.images[index].removed = (this.getFileElement(file, 'cell-remove input').checked ? 1 : 0);
         this.images[index].disabled = (this.getFileElement(file, 'cell-disable input').checked ? 1 : 0);
         this.getElement('save').value = JSON.stringify(this.images);
-        this.updateState(file);
         this.container.setHasChanges();
     }
     loadImage(file) {
@@ -213,10 +212,6 @@ Product.Gallery = class {
                 this.getFileElement(file, 'cell-' + pair[0] + ' input').checked = true;
             }
         }.bind(this));
-        this.updateState(file);
-    }
-    updateState(file) {
-        // deprecated
     }
     getFileElement(file, element) {
         var selector = '#' + this.prepareId(file) + ' .' + element;
@@ -912,14 +907,21 @@ showNoticeMessage() {
 
 var onInitDisableFieldsList = [];
 
-function toogleFieldEditMode(toogleIdentifier, fieldContainer) {
-    if (document.getElementById(toogleIdentifier).checked) {
+function toggleFieldEditMode(toggleIdentifier, fieldContainer) {
+    const el = (toggleIdentifier instanceof HTMLElement) ? toggleIdentifier : document.getElementById(toggleIdentifier);
+    if (el && el.checked) {
         enableFieldEditMode(fieldContainer);
     } else {
         disableFieldEditMode(fieldContainer);
     }
 }
 
+/** @deprecated since 26.3 Use toggleFieldEditMode instead */
+function toogleFieldEditMode(toogleIdentifier, fieldContainer) {
+    console.warn('toogleFieldEditMode is deprecated, use toggleFieldEditMode instead');
+    toggleFieldEditMode(toogleIdentifier, fieldContainer);
+}
+
 function disableFieldEditMode(fieldContainer) {
     if (document.getElementById(fieldContainer)) {
         document.getElementById(fieldContainer).disabled = true;