Accessibility: SVGs icon should have role="none", but how?

[fballiano]

While working on accessibility for our default theme I stumbled upon this:

we could:

• modify the getIconSvgmethod, adding a new role parameter (default=none) that injects the role attribute (not a super fan of this, since it would be the third parameter, making everybody having to specify the second parameter in order to use it...)
• modify our mahocommerce/icons library, automatically injecting role="none" on every svg file (not a fan of this either) but it's probably ok

@justinbeaty, any other ideas?

[justinbeaty]

modify the getIconSvgmethod, adding a new role parameter (default=none) that injects the role attribute (not a super fan of this, since it would be the third parameter, making everybody having to specify the second parameter in order to use it...)

If we do this one, could we just recommend the use of named parameters? So:

$this->getIconSvg('heart', role: 'button');

Alternatively turn the second argument into an option array, but I think that's pretty similar to named parameters in the end, but without native type support.

[fballiano]

because we can't use "role=none" for everything and that's it, right?

[justinbeaty]

I think for the usages in core Maho, role="none" is probably always correct. But if we do want to allow it to be specified I was more just commenting that the named params could solve needing the 2nd argument.

[fballiano]

done it in b05bd9b 😊😊

[fballiano]

category page is now at 92%, will work on fix all issues at least for category and product pages ASAP

[justinbeaty]

That's awesome!