Skip to content

Commit 648b145

Browse files
committed
Merge branch 'release/1.2.3'
2 parents f89482d + 462e76f commit 648b145

File tree

7 files changed

+24
-14
lines changed

7 files changed

+24
-14
lines changed

Podfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ DEPENDENCIES:
77
- MASShortcut
88

99
SPEC REPOS:
10-
https://github.com/cocoapods/specs.git:
10+
https://github.com/CocoaPods/Specs.git:
1111
- MASShortcut
1212

1313
EXTERNAL SOURCES:
@@ -25,4 +25,4 @@ SPEC CHECKSUMS:
2525

2626
PODFILE CHECKSUM: 22990987400160704799d9a65bb9be8983c907a2
2727

28-
COCOAPODS: 1.7.3
28+
COCOAPODS: 1.8.4

Press/Automation.png

573 KB
Loading

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,7 @@ macOS app for rating music in iTunes/Music.app
1414
## FAQ
1515
### How can I check the track rating in iTunes/Music.app?
1616
Check the checkbox for "Star Ratings" in General preferences. [More info](https://support.apple.com/guide/music/general-preferences-mus4130f48/mac)
17+
18+
### Why Song Rating not show star rating when iTunes/Music playing?
19+
Please check the Security & Privacy settings and check the checkbox of Song Rating.
20+
![Automation](./Press/Automation.png)

Song Rating.xcodeproj/project.pbxproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -768,15 +768,15 @@
768768
CODE_SIGN_IDENTITY = "Apple Development";
769769
CODE_SIGN_STYLE = Automatic;
770770
COMBINE_HIDPI_IMAGES = YES;
771-
CURRENT_PROJECT_VERSION = 7;
771+
CURRENT_PROJECT_VERSION = 8;
772772
DEVELOPMENT_TEAM = A8K92XFF77;
773773
ENABLE_HARDENED_RUNTIME = YES;
774774
INFOPLIST_FILE = "Song Rating/Info.plist";
775775
LD_RUNPATH_SEARCH_PATHS = (
776776
"$(inherited)",
777777
"@executable_path/../Frameworks",
778778
);
779-
MARKETING_VERSION = 1.2.2;
779+
MARKETING_VERSION = 1.2.3;
780780
PRODUCT_BUNDLE_IDENTIFIER = "com.mainasuk.Song-Rating";
781781
PRODUCT_NAME = "$(TARGET_NAME)";
782782
PROVISIONING_PROFILE_SPECIFIER = "";
@@ -796,15 +796,15 @@
796796
CODE_SIGN_IDENTITY = "Apple Development";
797797
CODE_SIGN_STYLE = Automatic;
798798
COMBINE_HIDPI_IMAGES = YES;
799-
CURRENT_PROJECT_VERSION = 7;
799+
CURRENT_PROJECT_VERSION = 8;
800800
DEVELOPMENT_TEAM = A8K92XFF77;
801801
ENABLE_HARDENED_RUNTIME = YES;
802802
INFOPLIST_FILE = "Song Rating/Info.plist";
803803
LD_RUNPATH_SEARCH_PATHS = (
804804
"$(inherited)",
805805
"@executable_path/../Frameworks",
806806
);
807-
MARKETING_VERSION = 1.2.2;
807+
MARKETING_VERSION = 1.2.3;
808808
PRODUCT_BUNDLE_IDENTIFIER = "com.mainasuk.Song-Rating";
809809
PRODUCT_NAME = "$(TARGET_NAME)";
810810
PROVISIONING_PROFILE_SPECIFIER = "";

Song Rating.xcodeproj/xcuserdata/mainasuk.xcuserdatad/xcschemes/xcschememanagement.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<key>Song Rating - Debug Memory.xcscheme_^#shared#^_</key>
88
<dict>
99
<key>orderHint</key>
10-
<integer>5</integer>
10+
<integer>0</integer>
1111
</dict>
1212
<key>Song Rating Helper.xcscheme_^#shared#^_</key>
1313
<dict>
@@ -17,7 +17,7 @@
1717
<key>Song Rating.xcscheme_^#shared#^_</key>
1818
<dict>
1919
<key>orderHint</key>
20-
<integer>6</integer>
20+
<integer>1</integer>
2121
</dict>
2222
<key>iTunesBridge.xcscheme_^#shared#^_</key>
2323
<dict>

Song Rating/iTunes/iTunesPlayerHistory.swift

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,12 @@ extension iTunesPlayerHistory {
3535
_tracks = _tracks.suffix(limit)
3636

3737
os_log("%{public}s[%{public}ld], %{public}s: playback history append track: %{public}s", ((#file as NSString).lastPathComponent), #line, #function, track.name ?? "null")
38-
38+
39+
/*
3940
for track in tracks {
40-
// print(track.name, track.databaseID)
41+
print(track.name, track.databaseID)
4142
}
43+
*/
4244
}
4345

4446
}

Song Rating/iTunes/iTunesRadioStation.swift

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,18 @@ final class iTunesRadioStation {
2222

2323
// MARK: - Singleton
2424
static let shared = iTunesRadioStation()
25+
26+
private lazy var _iTunes: iTunesApplication? = {
27+
let application = SBApplication(bundleIdentifier: OSVersionHelper.bundleIdentifier)
28+
application?.delegate = self
29+
return application
30+
}()
2531

2632
var iTunes: iTunesApplication? {
27-
let application = SBApplication(bundleIdentifier: OSVersionHelper.bundleIdentifier)
28-
guard application?.isRunning == true else {
33+
guard _iTunes?.isRunning == true else {
2934
return nil
3035
}
31-
application?.delegate = self
32-
return application
36+
return _iTunes
3337
}
3438

3539
private(set) var latestPlayInfo: PlayInfo? {

0 commit comments

Comments
 (0)