logging: always stringify job args, regardless of whether there are any.

Author: Majsvaffla

src/dreng/logging.py

@@ -10,8 +10,8 @@
 
 class JobArgsFilter(logging.Filter):
     def filter(self, record: logging.LogRecord) -> logging.LogRecord:
-        if (job := getattr(record, "job", {})) and isinstance(job, dict) and (args := job.get("args")):
-            job["args"] = str(args)[:1000]  # Avoid "overflowing" logging infrastructure.
+        if (job := getattr(record, "job", {})) and isinstance(job, dict) and "args" in job:
+            job["args"] = str(job["args"])[:1000]  # Avoid "overflowing" logging infrastructure.
         return record
 
 

tests/logging.py

@@ -11,16 +11,15 @@
     ("extra", "expected_job"),
     [
         (
-            {"slack": {"chill": True}, "job": {"some_number": 123, "args": [1, 2, 3]}},
+            {"job": {"some_number": 123, "args": [1, 2, 3]}},
             {"some_number": 123, "args": "[1, 2, 3]"},
         ),
         (
-            {"slack": {"chill": True}},
+            {},
             {},
         ),
         (
             {
-                "slack": {"chill": True},
                 "job": {
                     "created_at": datetime_utc(2025, 12, 25, 13, 37),
                     "execute_at": datetime_utc(2025, 12, 24, 14, 47),
@@ -30,19 +29,28 @@
         ),
         (
             {
-                "slack": {"chill": True},
                 "job": {
                     "created_at": TransactionNow(),
                     "execute_at": TransactionNow(),
                 },
             },
             {"created_at": None, "execute_at": None},
         ),
+        (
+            {"job": {"args": {}}},
+            {"args": r"{}"},
+        ),
     ],
 )
 def test_JobArgsFilter(caplog: pytest.LogCaptureFixture, extra: dict[str, Any], expected_job: dict[str, Any]) -> None:
     logger = logging.getLogger("tests")
-    logger.info("Working hard or hardly working?", extra=extra)
+    logger.info(
+        "Working hard or hardly working?",
+        extra={
+            **extra,
+            "slack": {"chill": True},  # Should always be kept as is.
+        },
+    )
     (record,) = caplog.records
     assert hasattr(record, "slack")
     assert record.slack["chill"] is True