Skip to content

Commit d8b1e44

Browse files
committed
refactor: drop unused params
1 parent 8f71221 commit d8b1e44

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

chores/management/commands/send_reminders.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,8 @@ def handle(self, *args, **kwargs):
4848
)
4949
for nudge in event.iter_nudges(params):
5050
logger.info("Processing Chore nudge: {0}".format(nudge))
51-
logger.debug("Processing Chore nudge: {0}".format(nudge))
52-
# Prevent multiple notifications using ChoreNotification
5351
logger.debug("nudge.get_string_key", nudge.get_string_key())
54-
nudge.send(self, logger)
52+
nudge.send()
5553

5654
self.stdout.write("Sending notifications")
5755

@@ -196,7 +194,7 @@ def get_string_key(self):
196194
self.nudge_key, event_key["chore_id"], event_key["ts"]
197195
)
198196

199-
def send(self, aggregator, logger):
197+
def send(self):
200198
"""Send the nudge - to be implemented by subclasses."""
201199
raise NotImplementedError("Subclasses must implement send()")
202200

@@ -229,7 +227,7 @@ def __str__(self):
229227
self.event.chore.name, self.destination, self.subject
230228
)
231229

232-
def send(self, aggregator, logger):
230+
def send(self):
233231
logger.info("Sending email nudge to: {0}".format(self.destination))
234232
logger.debug("EmailNudge.send", self.destination)
235233

@@ -260,7 +258,7 @@ def __init__(self, event, params):
260258
def __str__(self):
261259
return "Volunteer reminder via Chat BOT: {0}".format(self.event.chore.name)
262260

263-
def send(self, aggregator, _logger):
261+
def send(self):
264262
logger.debug("VolunteersReminderNudge.Send", len(self.volunteers))
265263
logger.info(
266264
"Sending volunteering reminder to: {0}".format(

chores/tests/factories.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ class UserFactory(factory.django.DjangoModelFactory):
88
class Meta:
99
model = User
1010

11-
email = factory.Faker('email')
12-
first_name = factory.Faker('first_name')
13-
last_name = factory.Faker('last_name')
14-
telegram_user_id = factory.Faker('uuid4')
15-
password = factory.PostGenerationMethodCall('set_password', 'password123')
11+
email = factory.Faker("email")
12+
first_name = factory.Faker("first_name")
13+
last_name = factory.Faker("last_name")
14+
telegram_user_id = factory.Faker("uuid4")
15+
password = factory.PostGenerationMethodCall("set_password", "password123")

0 commit comments

Comments
 (0)