Remove old email handling (#175)

* Remove unused email lookup

* Remove old email edit handling that was never fully implemented

Author: Lan2u

src/commands/members/edit-email.ts

@@ -1,4 +1,3 @@
-import {editEmail} from './edit-email';
 import {editName} from './edit-name';
 import {editNameForm} from './edit-name-form';
 import {editFormOfAddress} from './edit-form-of-address';
@@ -11,9 +10,6 @@ export const members = {
     ...editName,
     ...editNameForm,
   },
-  editEmail: {
-    ...editEmail,
-  },
   editFormOfAddress: {
     ...editFormOfAddress,
     ...editFormOfAddressForm,

src/commands/members/index.ts

@@ -10,7 +10,6 @@ export type Member = {
   trainedOn: ReadonlyArray<TrainedOn>;
   memberNumber: number;
   emailAddress: EmailAddress;
-  prevEmails: ReadonlyArray<EmailAddress>;
   name: O.Option<string>;
   formOfAddress: O.Option<string>;
   agreementSigned: O.Option<Date>;

src/read-models/members/return-types.ts

@@ -48,9 +48,6 @@ export const mergeMemberCore = (
       RA.filter(m => m !== memberNumber)
     ),
     emailAddress,
-    prevEmails: records
-      .flatMap(e => [...e.prevEmails, e.emailAddress])
-      .filter(e => e !== emailAddress),
     name: records[0].name,
     formOfAddress: records[0].formOfAddress,
     agreementSigned: records[0].agreementSigned,

src/read-models/shared-state/member/merge.ts

@@ -56,7 +56,6 @@ export type MemberCoreInfo = {
   memberNumber: number;
   pastMemberNumbers: ReadonlyArray<number>;
   emailAddress: EmailAddress;
-  prevEmails: ReadonlyArray<EmailAddress>;
   name: O.Option<string>;
   formOfAddress: O.Option<string>;
   agreementSigned: O.Option<Date>;

src/read-models/shared-state/return-types.ts

@@ -10,9 +10,6 @@ export const membersTable = sqliteTable('members', {
   formOfAddress: blob('formOfAddress', {mode: 'json'})
     .notNull()
     .$type<O.Option<string>>(),
-  prevEmails: blob('prevEmails', {mode: 'json'})
-    .notNull()
-    .$type<ReadonlyArray<EmailAddress>>(),
   isSuperUser: integer('isSuperUser', {mode: 'boolean'}).notNull(),
   superUserSince: integer('superUserSince', {mode: 'timestamp_ms'}),
   agreementSigned: integer('agreementSigned', {mode: 'timestamp_ms'}),
@@ -27,7 +24,6 @@ const createMembersTable = sql`
     gravatarHash TEXT,
     name BLOB,
     formOfAddress BLOB,
-    prevEmails BLOB,
     isSuperUser INTEGER,
     superUserSince INTEGER,
     agreementSigned INTEGER,

src/read-models/shared-state/state.ts

@@ -37,7 +37,6 @@ export const updateState =
             gravatarHash: gravatarHashFromEmail(event.email),
             name: O.fromNullable(event.name),
             formOfAddress: O.fromNullable(event.formOfAddress),
-            prevEmails: [],
             isSuperUser: false,
             agreementSigned: undefined,
             superUserSince: undefined,
@@ -60,24 +59,6 @@ export const updateState =
             .run();
         }
         break;
-      case 'MemberEmailChanged': {
-        const current = db
-          .select()
-          .from(membersTable)
-          .where(eq(membersTable.memberNumber, event.memberNumber))
-          .get();
-        if (current) {
-          db.update(membersTable)
-            .set({
-              emailAddress: event.newEmail,
-              prevEmails: [...current.prevEmails, current.emailAddress],
-              gravatarHash: gravatarHashFromEmail(event.newEmail),
-            })
-            .where(eq(membersTable.memberNumber, event.memberNumber))
-            .run();
-        }
-        break;
-      }
       case 'SuperUserDeclared':
         db.update(membersTable)
           .set({isSuperUser: true, superUserSince: event.recordedAt})

src/read-models/shared-state/update-state.ts

@@ -163,11 +163,6 @@ const RevokeTrainedOnEquipment = defineEvent('RevokeTrainedOnEquipment', {
   revokedByMemberNumber: t.union([t.number, t.null]), // Null to indicate system.
 });
 
-const MemberEmailChanged = defineEvent('MemberEmailChanged', {
-  memberNumber: t.number,
-  newEmail: EmailAddressCodec,
-});
-
 const RecurlySubscriptionUpdated = defineEvent('RecurlySubscriptionUpdated', {
   email: EmailAddressCodec,
   hasActiveSubscription: t.boolean,
@@ -218,7 +213,6 @@ export const events = [
   MemberTrainedOnEquipment,
   MemberTrainedOnEquipmentBy,
   RevokeTrainedOnEquipment,
-  MemberEmailChanged,
   EquipmentTrainingQuizMemberNumberUpdated,
   EquipmentTrainingQuizEmailUpdated,
   TroubleTicketResponseSubmitted,
@@ -249,7 +243,6 @@ export const DomainEvent = t.union([
   MemberTrainedOnEquipment.codec,
   MemberTrainedOnEquipmentBy.codec,
   RevokeTrainedOnEquipment.codec,
-  MemberEmailChanged.codec,
   EquipmentTrainingQuizMemberNumberUpdated.codec,
   EquipmentTrainingQuizEmailUpdated.codec,
   TroubleTicketResponseSubmitted.codec,

src/types/domain-event.ts

@@ -283,33 +283,6 @@ describe('get-via-shared-read-model', () => {
       });
     });
 
-    describe('and their email has changed', () => {
-      beforeEach(async () => {
-        await framework.commands.members.editEmail({
-          memberNumber,
-          email: 'updated@example.com' as EmailAddress,
-        });
-      });
-
-      it('returns the latest email', () => {
-        const result = runQuery();
-        expect(result.emailAddress).toBe('updated@example.com');
-      });
-
-      it('returns a record of previous emails', () => {
-        const result = runQuery();
-        expect(result.prevEmails).toHaveLength(1);
-        expect(result.prevEmails[0]).toStrictEqual('foo@example.com');
-      });
-
-      it('returns gravatar hash based on latest email', () => {
-        const result = runQuery();
-        expect(result.gravatarHash).toStrictEqual(
-          gravatarHashFromEmail('updated@example.com')
-        );
-      });
-    });
-
     describe('and they have been declared a super user', () => {
       const firstMadeSuperUserAt = faker.date.anytime();
       const superUserRevokedAt = faker.date.future({

tests/read-models/shared-state/get-member.test.ts

@@ -151,7 +151,6 @@ export const initTestFramework = async (): Promise<TestFramework> => {
         editName: frameworkify(commands.members.editName),
         editFormOfAddress: frameworkify(commands.members.editFormOfAddress),
         signOwnerAgreement: frameworkify(commands.members.signOwnerAgreement),
-        editEmail: frameworkify(commands.members.editEmail),
       },
       memberNumbers: {
         linkNumberToEmail: frameworkify(