Skip to content

Commit 344caa4

Browse files
committed
Reduce spans so we stay below performance units allocated
1 parent aeac5fa commit 344caa4

File tree

1 file changed

+13
-32
lines changed

1 file changed

+13
-32
lines changed

src/read-models/shared-state/async-refresh.ts

Lines changed: 13 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import {getAllEvents} from '../../init-dependencies/event-store/get-all-events';
44
import {pipe} from 'fp-ts/lib/function';
55
import {DomainEvent} from '../../types';
66
import * as TE from 'fp-ts/TaskEither';
7-
import {Span, startSpan} from '@sentry/node';
87

98
function payloadToString(payload: unknown): string {
109
return JSON.stringify(payload);
@@ -15,36 +14,18 @@ export const asyncRefresh = (
1514
updateState: (event: DomainEvent) => void
1615
) => {
1716
let knownEvents = 0;
18-
return () => () =>
19-
startSpan(
20-
{
21-
name: 'Async Refresh',
22-
attributes: {
23-
known_events_before: knownEvents,
24-
},
25-
},
26-
async (parentSpan: Span) => {
27-
const events = await startSpan(
28-
{name: 'Get All Events'},
29-
async (span: Span) => {
30-
const result = await pipe(
31-
getAllEvents(eventStoreDb)(),
32-
TE.getOrElse(failure => {
33-
throw new Error(
34-
`unexpected Left from getAllEvents: ${failure.message} ${payloadToString(failure.payload)}`
35-
);
36-
})
37-
)();
38-
span.setAttribute('event_count', result.length);
39-
return result;
40-
}
17+
return () => async () => {
18+
const events = await pipe(
19+
getAllEvents(eventStoreDb)(),
20+
TE.getOrElse(failure => {
21+
throw new Error(
22+
`unexpected Left from getAllEvents: ${failure.message} ${payloadToString(failure.payload)}`
4123
);
42-
43-
if (events.length > knownEvents) {
44-
events.slice(knownEvents - events.length).forEach(updateState);
45-
knownEvents = events.length;
46-
}
47-
parentSpan.setAttribute('known_events_after', knownEvents);
48-
}
49-
);
24+
})
25+
)();
26+
if (events.length > knownEvents) {
27+
events.slice(knownEvents - events.length).forEach(updateState);
28+
knownEvents = events.length;
29+
}
30+
};
5031
};

0 commit comments

Comments
 (0)