Pass dependencies to command

Author: Lan2u

src/commands/apply-command-to-resource.ts

@@ -1,18 +1,16 @@
 import {pipe} from 'fp-ts/lib/function';
 import * as TE from 'fp-ts/TaskEither';
+import * as O from 'fp-ts/Option';
 import {Command} from '.';
-import {Dependencies} from '../dependencies';
 import {Actor} from '../types/actor';
 import {
   FailureWithStatus,
-  failureWithStatus,
 } from '../types/failure-with-status';
 import {StatusCodes} from 'http-status-codes';
-
-type Deps = Pick<Dependencies, 'commitEvent' | 'getResourceEvents'>;
+import { CommandDependencies } from './command';
 
 export const applyToResource =
-  <T>(deps: Deps, command: Command<T>) =>
+  <T>(deps: CommandDependencies, command: Command<T>) =>
   (
     input: T,
     actor: Actor
@@ -26,13 +24,9 @@ export const applyToResource =
       resource,
       deps.getResourceEvents,
       TE.bind('event', ({events}) =>
-        pipe(
-          command.process({command: inputAndActor, events}),
-          TE.fromOption(() =>
-            failureWithStatus('no new event raised', StatusCodes.OK)()
-          )
-        )
+        command.process({command: inputAndActor, events, deps}),
       ),
-      TE.chain(({event, version}) => deps.commitEvent(resource, version)(event))
+      // If no event is raised then we still treat it as success to the user as they don't care about the difference -> if we want to raise an error then use TE.Left.
+      TE.chain(({event, version}) => O.isSome(event) ? deps.commitEvent(resource, version)(event.value) : TE.right({status: StatusCodes.CREATED, message: 'Success'}))
     );
   };

src/commands/area/set-mailing-list.ts

@@ -1,8 +1,9 @@
-import {constructEvent} from '../../types';
+import {constructEvent, DomainEvent} from '../../types';
 import * as t from 'io-ts';
 import * as tt from 'io-ts-types';
 import * as O from 'fp-ts/Option';
 import * as E from 'fp-ts/Either';
+import * as TE from 'fp-ts/TaskEither';
 import {pipe} from 'fp-ts/lib/function';
 import {Command} from '../command';
 import {isAdminOrSuperUser} from '../is-admin-or-super-user';
@@ -27,6 +28,7 @@ const process: Command<SetMailingList>['process'] = input => {
       email,
     })),
     O.map(constructEvent('AreaEmailUpdated')),
+    TE.right,
   );
 };
 

src/commands/command.ts

@@ -7,14 +7,16 @@ import {Resource} from '../types/resource';
 import { FailureWithStatus } from '../types/failure-with-status';
 import { Dependencies } from '../dependencies';
 
+export type CommandDependencies = Pick<Dependencies, 'commitEvent' | 'getResourceEvents' | 'excludeEvent'>;
+
 export type WithActor<T> = T & {actor: Actor};
 
 export type Command<T> = {
   resource: (command: T) => Resource;
   process: (input: {
     command: WithActor<T>;
     events: ReadonlyArray<DomainEvent>;
-    deps: Dependencies;
+    deps: CommandDependencies;
   }) => TE.TaskEither<FailureWithStatus, O.Option<DomainEvent>>;
   decode: Type<T, T, unknown>['decode'];
   isAuthorized: (input: {

tests/read-models/test-framework.ts

@@ -27,6 +27,7 @@ import {lastSync} from '../../src/sync-worker/db/last_sync';
 import {getSheetData, getSheetDataByMemberNumber} from '../../src/sync-worker/db/get_sheet_data';
 import {TrainingSummaryDeps} from '../../src/sync-worker/training-summary/training-summary-deps';
 import {NonEmptyString} from 'io-ts-types/lib/NonEmptyString';
+import { excludeEvent } from '../../src/init-dependencies/event-store/exclude-event';
 
 const TROUBLE_TICKET_SHEET_ID = 'trouble_ticket_sheet_id';
 
@@ -87,6 +88,8 @@ export const initTestFramework = async (): Promise<TestFramework> => {
   const frameworkGetAllEventsByType = <EN extends EventName>(eventType: EN) =>
     pipe(getAllEventsByType(eventDB)(eventType), T.map(getRightOrFail))();
 
+  const frameworkExcludeEvent = excludeEvent(eventDB);
+
   const frameworkify =
     <T>(command: Command<T>) =>
     async (commandPayload: T & {actor?: Actor}) => {
@@ -95,6 +98,7 @@ export const initTestFramework = async (): Promise<TestFramework> => {
           {
             commitEvent: frameworkCommitEvent,
             getResourceEvents: getResourceEvents(eventDB),
+            excludeEvent: frameworkExcludeEvent
           },
           command
         )(commandPayload, commandPayload.actor ?? arbitraryActor())