Skip to content

Commit 11b207f

Browse files
committed
add Aqua.jl tests and remove method ambiguity
1 parent 804da2d commit 11b207f

File tree

4 files changed

+20
-3
lines changed

4 files changed

+20
-3
lines changed

Project.toml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,30 @@ SimpleTraits = "699a6c99-e7fa-54fc-8d76-47d257e15c1d"
1515
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
1616

1717
[compat]
18+
Aqua = "0.8"
19+
CairoMakie = "0.11"
1820
DataStructures = "0.17, 0.18"
21+
FileIO = "1"
1922
GeometryBasics = "0.4"
2023
Graphs = "1.4"
24+
LinearAlgebra="1"
25+
Literate = "2"
2126
Makie = "0.20"
2227
NetworkLayout = "0.4.3"
2328
PolynomialRoots = "1"
29+
ReferenceTests = "0.10"
2430
SimpleTraits = "0.9"
2531
StaticArrays = "1.2"
32+
Test = "1"
2633
julia = "1"
2734

2835
[extras]
36+
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
2937
CairoMakie = "13f3f980-e62b-5c42-98c6-ff1f3baf88f0"
3038
FileIO = "5789e2e9-d7fb-5bc7-8068-2c6fae9b9549"
3139
Literate = "98b081ad-f1c9-55d3-8b20-4c87d4299306"
3240
ReferenceTests = "324d217c-45ce-50fc-942e-d289b448e8cf"
3341
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
3442

3543
[targets]
36-
test = ["CairoMakie", "FileIO", "Literate", "ReferenceTests", "Test"]
44+
test = ["Aqua", "CairoMakie", "FileIO", "Literate", "ReferenceTests", "Test"]

src/beziercurves.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ Method: Calculates the square distance between `pt` and path `p` and minimizes (
8989
let a = p0 - pt, b = p - p0
9090
t = -(a[1]*b[1] + a[2]*b[2]) / (b[1]^2 + b[2]^2)
9191
"""
92-
function inverse_interpolate(p::BezierPath{<:Point2}, pt)
92+
function inverse_interpolate(p::BezierPath{<:Point2}, pt::Point2)
9393
p0 = p.commands[end-1].p
9494
c = p.commands[end]
9595
N = length(p.commands) - 1
@@ -103,7 +103,7 @@ function inverse_interpolate(p::BezierPath{<:Point2}, pt)
103103
return t
104104
end
105105

106-
function inverse_interpolate(l::Line{PT}, pt) where PT
106+
function inverse_interpolate(l::Line{PT}, pt::PT) where PT
107107
a = l.p0 - pt
108108
b = l.p - l.p0
109109
t = -(a[1]*b[1] + a[2]*b[2]) / (b[1]^2 + b[2]^2)

test/Aqua.jl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
using Aqua
2+
using GeometryBasics
3+
4+
Aqua.test_ambiguities(GraphMakie)
5+
Aqua.test_all(GraphMakie;
6+
ambiguities=false,
7+
unbound_args=false)

test/runtests.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ using Makie.Colors
66
using StaticArrays
77
using Test
88

9+
include("Aqua.jl")
10+
911
include("beziercurves_test.jl")
1012

1113
@testset "GraphMakie.jl" begin

0 commit comments

Comments
 (0)