Commit 0643dc4
fix(annotation): Show lines/arrows when text is blank (#5560)
The compute graph refactor in #5448 dropped the `isfinite_rect` guard
that handled empty text bounding boxes. `Rect3d()` (the default for
empty strings) has Inf/-Inf origin/widths, causing `startpoint()` to
return NaN and making all annotation geometry invisible.
Closes #5557
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent a331267 commit 0643dc4
File tree
3 files changed
+9
-1
lines changed- Makie/src/basic_recipes
- ReferenceTests/src/tests
3 files changed
+9
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
5 | 7 | | |
6 | 8 | | |
7 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
| 233 | + | |
| 234 | + | |
233 | 235 | | |
234 | | - | |
| 236 | + | |
235 | 237 | | |
236 | 238 | | |
237 | 239 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2462 | 2462 | | |
2463 | 2463 | | |
2464 | 2464 | | |
| 2465 | + | |
| 2466 | + | |
| 2467 | + | |
| 2468 | + | |
2465 | 2469 | | |
2466 | 2470 | | |
2467 | 2471 | | |
| |||
0 commit comments