Skip to content

Commit 178f2d3

Browse files
authored
chore: use https urls in tests and README (apache#1016)
1 parent 1e8599a commit 178f2d3

File tree

2 files changed

+42
-42
lines changed

2 files changed

+42
-42
lines changed

README.md

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ You can show helpful articles, videos, and web resources inside of your app. Use
3232
3333
This plugin provides a web browser view that displays when calling `cordova.InAppBrowser.open()`.
3434

35-
var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'location=yes');
35+
var ref = cordova.InAppBrowser.open('https://apache.org', '_blank', 'location=yes');
3636

3737
### `window.open`
3838

@@ -166,7 +166,7 @@ instance, or the system browser.
166166

167167
### Example
168168

169-
var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'location=yes');
169+
var ref = cordova.InAppBrowser.open('https://apache.org', '_blank', 'location=yes');
170170
var ref2 = cordova.InAppBrowser.open(encodeURI('http://ja.m.wikipedia.org/wiki/ハングル'), '_blank', 'location=yes');
171171

172172
### OSX Quirks
@@ -353,7 +353,7 @@ function messageCallBack(params){
353353

354354
### Quick Example
355355

356-
var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'location=yes');
356+
var ref = cordova.InAppBrowser.open('https://apache.org', '_blank', 'location=yes');
357357
ref.addEventListener('loadstart', function(event) { alert(event.url); });
358358

359359
## InAppBrowser.removeEventListener
@@ -384,7 +384,7 @@ The function is passed an `InAppBrowserEvent` object.
384384

385385
### Quick Example
386386

387-
var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'location=yes');
387+
var ref = cordova.InAppBrowser.open('https://apache.org', '_blank', 'location=yes');
388388
var myCallback = function(event) { alert(event.url); }
389389
ref.addEventListener('loadstart', myCallback);
390390
ref.removeEventListener('loadstart', myCallback);
@@ -406,7 +406,7 @@ The function is passed an `InAppBrowserEvent` object.
406406

407407
### Quick Example
408408

409-
var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'location=yes');
409+
var ref = cordova.InAppBrowser.open('https://apache.org', '_blank', 'location=yes');
410410
ref.close();
411411

412412
## InAppBrowser.show
@@ -426,7 +426,7 @@ The function is passed an `InAppBrowserEvent` object.
426426

427427
### Quick Example
428428

429-
var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'hidden=yes');
429+
var ref = cordova.InAppBrowser.open('https://apache.org', '_blank', 'hidden=yes');
430430
// some time later...
431431
ref.show();
432432

@@ -446,7 +446,7 @@ The function is passed an `InAppBrowserEvent` object.
446446

447447
### Quick Example
448448

449-
var ref = cordova.InAppBrowser.open('http://apache.org', '_blank');
449+
var ref = cordova.InAppBrowser.open('https://apache.org', '_blank');
450450
// some time later...
451451
ref.hide();
452452

@@ -478,7 +478,7 @@ The function is passed an `InAppBrowserEvent` object.
478478

479479
### Quick Example
480480

481-
var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'location=yes');
481+
var ref = cordova.InAppBrowser.open('https://apache.org', '_blank', 'location=yes');
482482
ref.addEventListener('loadstop', function() {
483483
ref.executeScript({file: "myscript.js"});
484484
});
@@ -513,7 +513,7 @@ Due to [MSDN docs](https://msdn.microsoft.com/en-us/library/windows.ui.xaml.cont
513513

514514
### Quick Example
515515

516-
var ref = cordova.InAppBrowser.open('http://apache.org', '_blank', 'location=yes');
516+
var ref = cordova.InAppBrowser.open('https://apache.org', '_blank', 'location=yes');
517517
ref.addEventListener('loadstop', function() {
518518
ref.insertCSS({file: "mystyles.css"});
519519
});
@@ -695,13 +695,13 @@ iab.open('local-url.html', 'random_string', 'location=no'); // loads in the InAp
695695
```
696696
var iab = cordova.InAppBrowser;
697697
698-
iab.open('http://whitelisted-url.com'); // loads in the Cordova WebView
699-
iab.open('http://whitelisted-url.com', '_self'); // loads in the Cordova WebView
700-
iab.open('http://whitelisted-url.com', '_system'); // loads in the system browser
701-
iab.open('http://whitelisted-url.com', '_blank'); // loads in the InAppBrowser
702-
iab.open('http://whitelisted-url.com', 'random_string'); // loads in the InAppBrowser
698+
iab.open('https://whitelisted-url.com'); // loads in the Cordova WebView
699+
iab.open('https://whitelisted-url.com', '_self'); // loads in the Cordova WebView
700+
iab.open('https://whitelisted-url.com', '_system'); // loads in the system browser
701+
iab.open('https://whitelisted-url.com', '_blank'); // loads in the InAppBrowser
702+
iab.open('https://whitelisted-url.com', 'random_string'); // loads in the InAppBrowser
703703
704-
iab.open('http://whitelisted-url.com', 'random_string', 'location=no'); // loads in the InAppBrowser, no location bar
704+
iab.open('https://whitelisted-url.com', 'random_string', 'location=no'); // loads in the InAppBrowser, no location bar
705705
706706
```
707707

@@ -710,11 +710,11 @@ iab.open('http://whitelisted-url.com', 'random_string', 'location=no'); // loads
710710
```
711711
var iab = cordova.InAppBrowser;
712712
713-
iab.open('http://url-that-fails-whitelist.com'); // loads in the InAppBrowser
714-
iab.open('http://url-that-fails-whitelist.com', '_self'); // loads in the InAppBrowser
715-
iab.open('http://url-that-fails-whitelist.com', '_system'); // loads in the system browser
716-
iab.open('http://url-that-fails-whitelist.com', '_blank'); // loads in the InAppBrowser
717-
iab.open('http://url-that-fails-whitelist.com', 'random_string'); // loads in the InAppBrowser
718-
iab.open('http://url-that-fails-whitelist.com', 'random_string', 'location=no'); // loads in the InAppBrowser, no location bar
713+
iab.open('https://url-that-fails-whitelist.com'); // loads in the InAppBrowser
714+
iab.open('https://url-that-fails-whitelist.com', '_self'); // loads in the InAppBrowser
715+
iab.open('https://url-that-fails-whitelist.com', '_system'); // loads in the system browser
716+
iab.open('https://url-that-fails-whitelist.com', '_blank'); // loads in the InAppBrowser
717+
iab.open('https://url-that-fails-whitelist.com', 'random_string'); // loads in the InAppBrowser
718+
iab.open('https://url-that-fails-whitelist.com', 'random_string', 'location=no'); // loads in the InAppBrowser, no location bar
719719
720720
```

tests/tests.js

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -657,49 +657,49 @@ exports.defineManualTests = function (contentEl, createActionButton) {
657657
createActionButton(
658658
'* target=Default',
659659
function () {
660-
doOpen('http://cordova.apache.org');
660+
doOpen('https://cordova.apache.org');
661661
},
662662
'openWhiteListed'
663663
);
664664
createActionButton(
665665
'* target=Default (window.open)',
666666
function () {
667-
doHookOpen('http://cordova.apache.org');
667+
doHookOpen('https://cordova.apache.org');
668668
},
669669
'openWhiteListedHook'
670670
);
671671
createActionButton(
672672
'* target=_self',
673673
function () {
674-
doOpen('http://cordova.apache.org', '_self');
674+
doOpen('https://cordova.apache.org', '_self');
675675
},
676676
'openWhiteListedSelf'
677677
);
678678
createActionButton(
679679
'target=_system',
680680
function () {
681-
doOpen('http://cordova.apache.org', '_system');
681+
doOpen('https://cordova.apache.org', '_system');
682682
},
683683
'openWhiteListedSystem'
684684
);
685685
createActionButton(
686686
'target=_blank',
687687
function () {
688-
doOpen('http://cordova.apache.org', '_blank');
688+
doOpen('https://cordova.apache.org', '_blank');
689689
},
690690
'openWhiteListedBlank'
691691
);
692692
createActionButton(
693693
'target=Random',
694694
function () {
695-
doOpen('http://cordova.apache.org', 'random_string');
695+
doOpen('https://cordova.apache.org', 'random_string');
696696
},
697697
'openWhiteListedRandom'
698698
);
699699
createActionButton(
700700
'* target=Random, no location bar',
701701
function () {
702-
doOpen('http://cordova.apache.org', 'random_string', 'location=no');
702+
doOpen('https://cordova.apache.org', 'random_string', 'location=no');
703703
},
704704
'openWhiteListedRandomNoLocation'
705705
);
@@ -708,49 +708,49 @@ exports.defineManualTests = function (contentEl, createActionButton) {
708708
createActionButton(
709709
'target=Default',
710710
function () {
711-
doOpen('http://www.apple.com');
711+
doOpen('https://www.apple.com');
712712
},
713713
'openNonWhiteListed'
714714
);
715715
createActionButton(
716716
'target=Default (window.open)',
717717
function () {
718-
doHookOpen('http://www.apple.com');
718+
doHookOpen('https://www.apple.com');
719719
},
720720
'openNonWhiteListedHook'
721721
);
722722
createActionButton(
723723
'target=_self',
724724
function () {
725-
doOpen('http://www.apple.com', '_self');
725+
doOpen('https://www.apple.com', '_self');
726726
},
727727
'openNonWhiteListedSelf'
728728
);
729729
createActionButton(
730730
'target=_system',
731731
function () {
732-
doOpen('http://www.apple.com', '_system');
732+
doOpen('https://www.apple.com', '_system');
733733
},
734734
'openNonWhiteListedSystem'
735735
);
736736
createActionButton(
737737
'target=_blank',
738738
function () {
739-
doOpen('http://www.apple.com', '_blank');
739+
doOpen('https://www.apple.com', '_blank');
740740
},
741741
'openNonWhiteListedBlank'
742742
);
743743
createActionButton(
744744
'target=Random',
745745
function () {
746-
doOpen('http://www.apple.com', 'random_string');
746+
doOpen('https://www.apple.com', 'random_string');
747747
},
748748
'openNonWhiteListedRandom'
749749
);
750750
createActionButton(
751751
'* target=Random, no location bar',
752752
function () {
753-
doOpen('http://www.apple.com', 'random_string', 'location=no');
753+
doOpen('https://www.apple.com', 'random_string', 'location=no');
754754
},
755755
'openNonWhiteListedRandomNoLocation'
756756
);
@@ -759,14 +759,14 @@ exports.defineManualTests = function (contentEl, createActionButton) {
759759
createActionButton(
760760
'http://google.co.uk',
761761
function () {
762-
doOpen('http://google.co.uk', 'random_string', '', 1);
762+
doOpen('https://google.co.uk', 'random_string', '', 1);
763763
},
764764
'openRedirect301'
765765
);
766766
createActionButton(
767767
'http://goo.gl/pUFqg',
768768
function () {
769-
doOpen('http://goo.gl/pUFqg', 'random_string', '', 2);
769+
doOpen('https://goo.gl/pUFqg', 'random_string', '', 2);
770770
},
771771
'openRedirect302'
772772
);
@@ -775,7 +775,7 @@ exports.defineManualTests = function (contentEl, createActionButton) {
775775
createActionButton(
776776
'Remote URL',
777777
function () {
778-
doOpen('http://www.stluciadance.com/prospectus_file/sample.pdf');
778+
doOpen('https://www.stluciadance.com/prospectus_file/sample.pdf');
779779
},
780780
'openPDF'
781781
);
@@ -798,7 +798,7 @@ exports.defineManualTests = function (contentEl, createActionButton) {
798798
createActionButton(
799799
'Invalid Host',
800800
function () {
801-
doOpen('http://www.inv;alid.com/', '_blank');
801+
doOpen('https://www.inv;alid.com/', '_blank');
802802
},
803803
'openInvalidHost'
804804
);
@@ -974,21 +974,21 @@ exports.defineManualTests = function (contentEl, createActionButton) {
974974
createActionButton(
975975
'no hardwareback (defaults to yes)',
976976
function () {
977-
doOpen('http://cordova.apache.org', '_blank');
977+
doOpen('https://cordova.apache.org', '_blank');
978978
},
979979
'openHardwareBackDefault'
980980
);
981981
createActionButton(
982982
'hardwareback=yes',
983983
function () {
984-
doOpen('http://cordova.apache.org', '_blank', 'hardwareback=yes');
984+
doOpen('https://cordova.apache.org', '_blank', 'hardwareback=yes');
985985
},
986986
'openHardwareBackYes'
987987
);
988988
createActionButton(
989989
'hardwareback=no',
990990
function () {
991-
doOpen('http://cordova.apache.org', '_blank', 'hardwareback=no');
991+
doOpen('https://cordova.apache.org', '_blank', 'hardwareback=no');
992992
},
993993
'openHardwareBackNo'
994994
);

0 commit comments

Comments
 (0)