Skip to content

Commit 7053bae

Browse files
author
Damion Werner
committed
final touches to k8s deployment
1 parent fa2ae77 commit 7053bae

File tree

6 files changed

+16
-11
lines changed

6 files changed

+16
-11
lines changed

malstrom-core/src/coordinator/coordinator.rs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ async fn coordinator_loop<C: Send + CoordinatorWorkerComm, P: Send + Persistence
245245
state: SerializableCoordinatorState,
246246
requests: flume::Receiver<CoordinatorRequest>,
247247
communication_backend: C,
248-
persistence_backend: P,
248+
mut persistence_backend: P,
249249
) -> Result<(), CoordinatorLoopError> {
250250
let mut state = CoordinatorState::from_serialized(state, &communication_backend).await?;
251251
// start job on all workers
@@ -290,10 +290,13 @@ async fn coordinator_loop<C: Send + CoordinatorWorkerComm, P: Send + Persistence
290290
perform_snapshot_all(&state, next_version).await;
291291

292292
let serialized_state = serialize_state(&state.get_serializable().await);
293-
persistence_backend
294-
.for_version(COORDINATOR_ID, &next_version)
295-
.persist(&serialized_state, &0);
296-
persistence_backend.commit_version(&next_version);
293+
persistence_backend = tokio::runtime::Handle::current().spawn_blocking(move || {
294+
persistence_backend
295+
.for_version(COORDINATOR_ID, &next_version)
296+
.persist(&serialized_state, &0);
297+
persistence_backend.commit_version(&next_version);
298+
persistence_backend
299+
}).await?;
297300
snapshot_version = Some(next_version);
298301
}
299302
RequestOperation::Scale(desired) => {

malstrom-k8s/artifact-manager/Rocket.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
address = "0.0.0.0"
33

44
[default.limits]
5-
file = "100MiB"
6-
"data-form" = "100MiB"
5+
file = "1024MiB"
6+
"data-form" = "1024MiB"

malstrom-k8s/operator/Cargo.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ readme = "Readme.md"
1111
authors = [
1212
"nico@acupof.xyz"
1313
]
14-
[lints]
15-
workspace = true
1614

1715
[[bin]]
1816
name = "k8s-operator"

malstrom-k8s/operator/crds/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ impl MalstromJob {
133133
spec: Some(ServiceSpec {
134134
cluster_ip: None,
135135
selector: Some(labels),
136-
publish_not_ready_addresses: Some(false),
136+
publish_not_ready_addresses: Some(true),
137137
ports: Some(Vec::from_iter([ServicePort {
138138
port: 29091,
139139
target_port: Some(IntOrString::Int(29091)),

malstrom-kafka/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ edition = "2021"
66
[dependencies]
77
bon = { version = "3.5.1", features = ["experimental-overwritable"] }
88
malstrom = { path = "../malstrom-core" }
9-
rdkafka = { version = "0.36.2"}
9+
rdkafka = { version = "0.37.0"}
1010
thiserror = "2.0.12"
1111
tracing = "0.1.41"
1212

website/guide/Kubernetes.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,10 @@ number greater than 0. The operator will then automatically take care of rescali
101101

102102
## Operator values
103103

104+
> [!WARNING]
105+
> Currently the operator only supports modifying the job replica count. Any other modification
106+
> requires manually deleting and re-creating the job. See [issue 25](https://github.com/MalstromDevelopers/malstrom/issues/25)
107+
104108
The operator helm chart supports these configuration values:
105109

106110
<<< @../../malstrom-k8s/operator/helm/malstrom-operator/values.yaml

0 commit comments

Comments
 (0)