Use all steps from a github actions workflow

Author: agrare

lib/manageiq/cross_repo/runner/base.rb

@@ -21,36 +21,6 @@ def build_test_script
 
       private
 
-      def environment_setup_commands
-        commands = []
-
-        if config["node_js"]
-          commands << "source ~/.nvm/nvm.sh"
-          commands += Array(config["node_js"]).map do |node_version|
-            "nvm install #{node_version}"
-          end
-        end
-
-        commands.any? ? build_section("environment", *commands) : commands
-      end
-
-      def section_commands
-        sections = %w[before_install install before_script script]
-        sections.flat_map do |section|
-          commands = build_section_commands(section)
-          build_section(section, *commands) if commands.present?
-        end.compact
-      end
-
-      def build_commands
-        environment_setup_commands + section_commands
-      end
-
-      def build_section_commands(section)
-        # Travis sections can have a single command or an array of commands
-        Array(config[section]).map { |cmd| "#{cmd} || exit $?" }
-      end
-
       def build_section(section, *commands)
         [
           "echo '::group::#{section}'",
@@ -60,16 +30,6 @@ def build_section(section, *commands)
       end
 
       def load_config!
-        ci_config.tap do |config|
-          # Set missing sections to the proper defaults
-          config["install"] ||= defaults[config["language"]]["install"]
-
-          config["script"] = script_cmd if script_cmd.present?
-          config["script"] ||= defaults[config["language"]]["script"]
-        end
-      end
-
-      def ci_config
         raise NotImplementedError, "must be implemented in a subclass"
       end
 

lib/manageiq/cross_repo/runner/github.rb

@@ -13,21 +13,29 @@ def self.available?
 
       private
 
-      def ci_config
-        github_config = YAML.load_file(CONFIG_FILE)
-
-        steps = github_config["jobs"]["ci"]["steps"]
-        steps_by_name = steps.index_by { |step| step["name"] }
-
-        language = steps.any? { |s| s["uses"] == "ruby/setup-ruby@v1" } ? "ruby" : "node_js"
-
-        result = {"language" => language}
+      def build_commands
+        config.dig("jobs", "ci", "steps").map do |step|
+          if step["run"].nil?
+            case step["uses"]
+            when /ruby\/setup-ruby/
+              step["run"] = defaults["ruby"]["install"]
+            when /actions\/setup-node/
+              step["run"] = defaults["node_js"]["install"]
+            else
+              next
+            end
+          end
+
+          build_section(step["name"], "#{step["run"]} || exit $?")
+        end.compact
+      end
 
-        result["before_install"] = steps_by_name["Set up system"]["run"] if steps_by_name["Set up system"]
-        result["before_script"]  = steps_by_name["Prepare tests"]["run"] if steps_by_name["Prepare tests"]
-        result["script"]         = steps_by_name["Run tests"]["run"]     if steps_by_name["Run tests"]
+      def load_config!
+        ci_config
+      end
 
-        result
+      def ci_config
+        YAML.load_file(CONFIG_FILE)
       end
     end
   end

lib/manageiq/cross_repo/runner/travis.rb

@@ -12,6 +12,46 @@ def self.available?
 
       private
 
+      def environment_setup_commands
+        commands = []
+
+        if config["node_js"]
+          commands << "source ~/.nvm/nvm.sh"
+          commands += Array(config["node_js"]).map do |node_version|
+            "nvm install #{node_version}"
+          end
+        end
+
+        commands.any? ? build_section("environment", *commands) : commands
+      end
+
+      def section_commands
+        sections = %w[before_install install before_script script]
+        sections.flat_map do |section|
+          commands = build_section_commands(section)
+          build_section(section, *commands) if commands.present?
+        end.compact
+      end
+
+      def build_commands
+        environment_setup_commands + section_commands
+      end
+
+      def build_section_commands(section)
+        # Travis sections can have a single command or an array of commands
+        Array(config[section]).map { |cmd| "#{cmd} || exit $?" }
+      end
+
+      def load_config!
+        ci_config.tap do |config|
+          # Set missing sections to the proper defaults
+          config["install"] ||= defaults[config["language"]]["install"]
+
+          config["script"] = script_cmd if script_cmd.present?
+          config["script"] ||= defaults[config["language"]]["script"]
+        end
+      end
+
       def ci_config
         YAML.load_file(CONFIG_FILE)
       end

spec/manageiq/cross_repo/runner/github_spec.rb

@@ -51,47 +51,22 @@
         expected_test_script = <<~SCRIPT
           #!/bin/bash
 
-          echo '::group::before_install'
+          echo '::group::Set up system'
           bin/before_install || exit $?
           echo '::endgroup::'
-          echo '::group::install'
+          echo '::group::Set up Ruby'
           bundle install --jobs=3 --retry=3 --path=${BUNDLE_PATH:-vendor/bundle} || exit $?
           echo '::endgroup::'
-          echo '::group::before_script'
+          echo '::group::Prepare tests'
           bin/setup || exit $?
           echo '::endgroup::'
-          echo '::group::script'
+          echo '::group::Run tests'
           bundle exec rake || exit $?
           echo '::endgroup::'
         SCRIPT
 
         expect(runner.build_test_script).to eq(expected_test_script)
       end
-
-      context "with a script_cmd" do
-        let(:script_cmd) { "cat db/schema.rb" }
-
-        it "builds a test script" do
-          expected_test_script = <<~SCRIPT
-            #!/bin/bash
-
-            echo '::group::before_install'
-            bin/before_install || exit $?
-            echo '::endgroup::'
-            echo '::group::install'
-            bundle install --jobs=3 --retry=3 --path=${BUNDLE_PATH:-vendor/bundle} || exit $?
-            echo '::endgroup::'
-            echo '::group::before_script'
-            bin/setup || exit $?
-            echo '::endgroup::'
-            echo '::group::script'
-            cat db/schema.rb || exit $?
-            echo '::endgroup::'
-          SCRIPT
-
-          expect(runner.build_test_script).to eq(expected_test_script)
-        end
-      end
     end
 
     # TODO: Add node_js when we have a node_js repo