Power operations on VM: start, stop and suspend

With this commit we implement power operations on a VM.

Signed-off-by: Miha Pleško <miha.plesko@xlab.si>

Author: Miha Pleško

app/models/manageiq/providers/azure_stack/cloud_manager/vm.rb

@@ -1,4 +1,5 @@
 class ManageIQ::Providers::AzureStack::CloudManager::Vm < ManageIQ::Providers::CloudManager::Vm
+  include ManageIQ::Providers::AzureStack::EmsRefMixin
 
   POWER_STATES = {
     'PowerState/running'      => 'on',
@@ -10,37 +11,27 @@ class ManageIQ::Providers::AzureStack::CloudManager::Vm < ManageIQ::Providers::C
     'PowerState/unknown'      => 'unknown'
   }.freeze
 
-  def provider_object(connection = nil)
-    connection ||= ext_management_system.connect
-    # find vm instance via connection and return it
-    # connection.find_instance(ems_ref)
-    # but we return just an object for now
-    OpenStruct.new
-  end
-
   def raw_start
-    with_provider_object(&:start)
-    # Temporarily update state for quick UI response until refresh comes along
-    update_attributes!(:raw_power_state => "on")
+    with_provider_connection(:service => :Compute) do |client|
+      client.virtual_machines.start(resource_group_name(ems_ref), name)
+    end
+    update!(:raw_power_state => 'PowerState/running')
   end
 
   def raw_stop
-    with_provider_object(&:stop)
-    # Temporarily update state for quick UI response until refresh comes along
-    update_attributes!(:raw_power_state => "off")
-  end
-
-  def raw_pause
-    with_provider_object(&:pause)
-    # Temporarily update state for quick UI response until refresh comes along
-    update_attributes!(:raw_power_state => "paused")
+    with_provider_connection(:service => :Compute) do |client|
+      client.virtual_machines.deallocate(resource_group_name(ems_ref), name)
+    end
+    update!(:raw_power_state => 'PowerState/deallocated')
   end
 
   def raw_suspend
-    with_provider_object(&:suspend)
-    # Temporarily update state for quick UI response until refresh comes along
-    update_attributes!(:raw_power_state => "suspended")
+    with_provider_connection(:service => :Compute) do |client|
+      client.virtual_machines.stop(resource_group_name(ems_ref), name)
+    end
+    update!(:raw_power_state => 'PowerState/stopped')
   end
+  alias raw_pause raw_suspend
 
   def self.calculate_power_state(raw_power_state)
     # https://docs.microsoft.com/en-us/azure/virtual-machines/windows/states-lifecycle

app/models/manageiq/providers/azure_stack/ems_ref_mixin.rb

@@ -0,0 +1,15 @@
+module ManageIQ::Providers::AzureStack::EmsRefMixin
+  extend ActiveSupport::Concern
+
+  def resource_group_name(ems_ref)
+    if (match = ems_ref.match(%r{/subscriptions/[^/]+/resourceGroups/(?<name>[^/]+)/.+}i))
+      match[:name].downcase
+    end
+  end
+
+  def resource_group_id(ems_ref)
+    if (match = ems_ref.match(%r{(?<id>/subscriptions/[^/]+/resourceGroups/[^/]+)/.+}i))
+      match[:id].downcase
+    end
+  end
+end

app/models/manageiq/providers/azure_stack/inventory/collector.rb

@@ -1,6 +1,8 @@
 class ManageIQ::Providers::AzureStack::Inventory::Collector < ManageIQ::Providers::Inventory::Collector
   require_nested :CloudManager
 
+  include ManageIQ::Providers::AzureStack::EmsRefMixin
+
   def initialize(manager, refresh_target)
     super(manager, refresh_target)
     @token = nil
@@ -24,18 +26,6 @@ def with_shared_token
     client
   end
 
-  def resource_group_name(ems_ref)
-    if (match = ems_ref.match(%r{/subscriptions/[^/]+/resourceGroups/(?<name>[^/]+)/.+}))
-      match[:name].downcase
-    end
-  end
-
-  def resource_group_id(ems_ref)
-    if (match = ems_ref.match(%r{(?<id>/subscriptions/[^/]+/resourceGroups/[^/]+)/.+}))
-      match[:id].downcase
-    end
-  end
-
   def raw_power_state(instance_view)
     instance_view&.statuses&.detect { |s| s.code.start_with?('PowerState/') }&.code
   end

spec/factories/vm.rb

@@ -0,0 +1,9 @@
+FactoryBot.define do
+  factory :vm_azure_stack, :class => 'ManageIQ::Providers::AzureStack::CloudManager::Vm', :parent => :vm_cloud do
+    sequence(:name) { |n| "VM#{n}" }
+    sequence(:ems_ref) do |n|
+      "/subscriptions/11111111-2222-3333-4444-555555555555/resourceGroups/RESOURCE_GROUP/providers/Microsoft.Compute/virtualMachines/VM#{n}"
+    end
+    raw_power_state { 'PowerState/running' }
+  end
+end

spec/models/manageiq/providers/azure_stack/cloud_manager/vm_spec.rb

@@ -0,0 +1,48 @@
+describe ManageIQ::Providers::AzureStack::CloudManager::Vm do
+  before { allow(subject).to receive(:with_provider_connection).with(:service => :Compute).and_yield(client) }
+
+  let(:client)  { double('compute', :virtual_machines => actions) }
+  let(:actions) { double('actions') }
+
+  subject { FactoryBot.create(:vm_azure_stack, :raw_power_state => 'unknown') }
+
+  describe '#raw_start' do
+    it 'invokes' do
+      expect(subject.power_state).to eq('unknown')
+      expect(actions).to receive(:start).with('resource_group', subject.name)
+      subject.raw_start
+      subject.reload
+      expect(subject.power_state).to eq('on')
+    end
+  end
+
+  describe '#raw_stop' do
+    it 'invokes' do
+      expect(subject.power_state).to eq('unknown')
+      expect(actions).to receive(:deallocate).with('resource_group', subject.name)
+      subject.raw_stop
+      subject.reload
+      expect(subject.power_state).to eq('off')
+    end
+  end
+
+  describe '#raw_suspend' do
+    it 'invokes' do
+      expect(subject.power_state).to eq('unknown')
+      expect(actions).to receive(:stop).with('resource_group', subject.name)
+      subject.raw_suspend
+      subject.reload
+      expect(subject.power_state).to eq('suspended')
+    end
+  end
+
+  describe '#raw_pause' do
+    it 'invokes' do
+      expect(subject.power_state).to eq('unknown')
+      expect(actions).to receive(:stop).with('resource_group', subject.name)
+      subject.raw_pause
+      subject.reload
+      expect(subject.power_state).to eq('suspended')
+    end
+  end
+end