Remove monkey patch for MSRestAzure

[Fryguy]

See

manageiq-providers-azure_stack/app/models/manageiq/providers/azure_stack/manager_mixin.rb

Line 88 in b8fe3ad

require 'patches/ms_rest_azure/password_token_provider' # https://github.com/Azure/azure-sdk-for-ruby/pull/2039

and

Azure/azure-sdk-for-ruby#2039

[mancabizjak]

We are thinking about retiring username+password authentication in the provider (hence removing the need for the patch) and substitute it with client-id + client-key authentication. This won't be a problem with the official ms_rest_azure gem we're using in the provider, and would also be aligned with how things are done in the Azure provider.

I plan to take this issue on shortly.

/cc @agrare @gberginc
@miq-bot assign @mancabizjak

[gberginc]

Thanks @mancabizjak! This will be super great to align with AZS itself.

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.