Add shared processor pool option to PowerVS provision form

Author: alizapeikes

app/models/manageiq/providers/ibm_cloud/power_virtual_servers/cloud_manager/provision/cloning.rb

@@ -70,6 +70,7 @@ def prepare_for_clone
     end
 
     specs['placement_group'] = get_option(:placement_group) unless get_option(:placement_group).nil?
+    specs['shared_processor_pool'] = get_option(:shared_processor_pool) unless get_option(:shared_processor_pool).nil?
     user_script_text = options[:user_script_text]
     user_script_text64 = Base64.encode64(user_script_text) unless user_script_text.nil?
     specs['user_data'] = user_script_text64 unless user_script_text64.nil?

app/models/manageiq/providers/ibm_cloud/power_virtual_servers/cloud_manager/provision_workflow.rb

@@ -128,6 +128,12 @@ def allowed_placement_groups(_options = {})
     ar_ems.placement_groups.to_h { |group| [group.ems_ref, "#{group.policy}: #{group.name}"] }
   end
 
+  def allowed_shared_processer_pools(_options = {})
+    return {} if ar_ems.nil?
+
+    ar_ems.resource_pools.to_h { |pool| [pool.ems_ref, pool.name] }
+  end
+
   def set_request_values(values)
     values[:new_volumes] = parse_new_volumes_fields(values)
     super
@@ -197,6 +203,19 @@ def validate_placement_group(_filed, _values, _dlg, _fld, value)
     _('Invalid placement group - incompatible colocation policy') unless valid
   end
 
+  def validate_shared_processer_pool(_filed, _values, _dlg, _fld, value)
+    return if value.blank?
+
+    resource_pool = ar_ems.resource_pools.find_by!(:ems_ref => value)
+    vms_in_resource_pool = resource_pool.vms
+    # We don't save a processor pool machine type in the db, so there is no way to validate an empty processor pool
+    return if vms_in_resource_pool.blank?
+
+    # Shared processor pools are used and shared by a set of virtual server instances of the same machine type (host).
+    valid = vms_in_resource_pool.first.flavor.name == values&.dig(:sys_type, 1)
+    _('Invalid processor pool - incompatible machine type (host)') unless valid
+  end
+
   private
 
   def ar_ems

content/miq_dialogs/miq_provision_ibm_powervs_dialogs_template.yaml

@@ -32,6 +32,15 @@
           :display: :edit
           :auto_select_single: false
           :data_type: :string
+        :shared_processor_pool:
+          :values_from:
+            :method: allowed_shared_processer_pools
+          :description: Shared Processor Pool
+          :required: false
+          :validation_method: :validate_shared_processer_pool
+          :display: :edit
+          :auto_select_single: false
+          :data_type: :string
         :pin_policy:
           :values:
             1: "none"