Merge pull request #122 from vfebvre/shmem

Add memory_type advanced setting (dedicated or shared) for VM & Templates

Author: agrare

app/models/manageiq/providers/ibm_power_hmc/inventory/parser/infra_manager.rb

@@ -469,6 +469,16 @@ def parse_vm_advanced_settings(vm, lpar)
       :value        => proc_type,
       :read_only    => true
     )
+
+    mem_type = lpar.shared_mem == "true" ? "shared" : "dedicated"
+    persister.vms_and_templates_advanced_settings.build(
+      :resource     => vm,
+      :name         => 'memory_type',
+      :display_name => _('Memory type'),
+      :description  => _('Dedicated or shared'),
+      :value        => mem_type,
+      :read_only    => true
+    )
   end
 
   def parse_templates

manageiq-providers-ibm_power_hmc.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "ibm_power_hmc", "~> 0.21.1"
+  spec.add_dependency "ibm_power_hmc", "~> 0.22.0"
 
   spec.add_development_dependency "manageiq-style"
   spec.add_development_dependency "simplecov", ">= 0.21.2"

spec/models/manageiq/providers/ibm_power_hmc/infra_manager/refresher_spec.rb

@@ -210,6 +210,12 @@ def assert_specific_vios
       :read_only => true
     )
 
+    setting = vios.advanced_settings.find_by(:name => "memory_type")
+    expect(setting).to have_attributes(
+      :value     => "dedicated",
+      :read_only => true
+    )
+
     expect(vios.labels.count).to eq(1)
     expect(vios.labels.first.name).to eq("ManageIQ")
 
@@ -274,6 +280,12 @@ def assert_specific_lpar
       :read_only => true
     )
 
+    setting = lpar.advanced_settings.find_by(:name => "memory_type")
+    expect(setting).to have_attributes(
+      :value     => "dedicated",
+      :read_only => true
+    )
+
     expect(lpar.labels.count).to eq(1)
     expect(lpar.labels.first.name).to eq("ManageIQ")
 
@@ -305,6 +317,12 @@ def assert_specific_template
       :value     => "uncapped",
       :read_only => true
     )
+
+    setting = template.advanced_settings.find_by(:name => "memory_type")
+    expect(setting).to have_attributes(
+      :value     => "dedicated",
+      :read_only => true
+    )
   end
 
   def assert_specific_resource_pool_cpu