Pod conditions fields != Node conditions fields

[cben]

We use one table and one parse_conditions() method for both pod & node status.conditions.
The fields we take match node conditions but not exactly pods. Specifically:

• nodes have lastHeartbeatTime which we parse & store;
• pods instead have lastProbeTime which we discard.

https://kubernetes.io/docs/api-reference/v1.8/#nodecondition-v1-core
https://kubernetes.io/docs/api-reference/v1.8/#podcondition-v1-core

Example from node:

    conditions:
    - lastHeartbeatTime: 2017-12-06T12:06:44Z
      lastTransitionTime: 2017-12-06T10:03:09Z
      message: kubelet has sufficient disk space available
      reason: KubeletHasSufficientDisk
      status: "False"
      type: OutOfDisk

example from pod:

  status:
    conditions:
    - lastProbeTime: null
      lastTransitionTime: 2017-12-06T10:19:15Z
      status: "True"
      type: Initialized

(but according to doc, may also have message and reason)

[moolitayer]

@cben will adding lastProbeTime solve our problem?
(and in the UI show what is available) where do we show/use these?

[cben]

I have no idea if there are any practical consequences :-) Just noticed it when looking at code vs API response... Yes, adding last_probe_time is only missing thing. And perhaps it'd be fine to stick it into last_heartbeat_time (perhaps renamed) — it's one OR the other, and both essentially mean "when this was checked".

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!