Skip to content

Conversation

@nasark
Copy link
Member

@nasark nasark commented Dec 10, 2024

Introducing a MetricsCaptureMixin will allow us to reuse this code in classes that should not subclass ContainerManager::MetricsCapture such as Kubevirt::InfraManager::MetricsCapture

Needed for:

@miq-bot assign @agrare
@miq-bot add_label refactoring
@miq-bot add_reviewer @Fryguy, @agrare

@Fryguy
Copy link
Member

Fryguy commented Dec 11, 2024

Love this refactoring

@miq-bot
Copy link
Member

miq-bot commented Mar 5, 2025

Checked commit nasark@9b91518 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 9 offenses detected

app/models/manageiq/providers/kubernetes/container_manager/metrics_capture_mixin.rb

@miq-bot miq-bot added the stale label Jun 9, 2025
@miq-bot
Copy link
Member

miq-bot commented Jun 9, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants