Drop boot_index -1

Author: agrare

app/models/manageiq/providers/openstack/cloud_manager/provision/volume_attachment.rb

@@ -10,8 +10,6 @@ def create_requested_volumes(requested_volumes)
             volume_attrs[:imageRef] = source.ems_ref # Set the image reference for booting
             volume_attrs[:bootable] = true
             volume_attrs[:boot_index] = 0
-          else # Subsequent volumes will be assigned to vdb, vdc, etc.
-            volume_attrs[:boot_index] = -1
           end
         end
 

spec/models/manageiq/providers/openstack/cloud_manager/provision/volume_attachment_spec.rb

@@ -43,11 +43,11 @@
       context "with multiple requested volumes" do
         let(:task_volumes) { [{:name => "custom_volume_1", :size => 2}, {:name => "custom_volume_2", :size => 4}] }
 
-        it "sets other volumes as boot_index -1" do
+        it "only sets boot_index for first volumes" do
           expected_volume_1 = {:name => "custom_volume_1", :size => 2, :uuid => volume.id, :source_type => "volume",
                                :destination_type => "volume", :boot_index => 0, :bootable => true, :imageRef => template.ems_ref}
           expected_volume_2 = {:name => "custom_volume_2", :size => 4, :uuid => volume.id, :source_type => "volume",
-                               :destination_type => "volume", :boot_index => -1}
+                               :destination_type => "volume"}
 
           expect(task.create_requested_volumes(task.options[:volumes])).to eq([expected_volume_1, expected_volume_2])
         end