Use ManageIQ::Loggers

Author: agrare

workers/event_catcher/event_catcher.rb

@@ -1,10 +1,11 @@
 require_relative "event_parser"
 
 class EventCatcher
-  def initialize(ems_id, default_endpoint, default_authentication, messaging, page_size = 20)
-    @ems_id                 = ems_id
+  def initialize(ems, default_endpoint, default_authentication, messaging, logger, page_size = 20)
+    @ems_id                 = ems["id"]
     @default_endpoint       = default_endpoint
     @default_authentication = default_authentication
+    @logger                 = logger
     @messaging              = messaging
     @page_size              = page_size
   end
@@ -16,13 +17,13 @@ def run!
 
     notify_started
 
-    puts "Collecting events..."
+    logger.info("Collecting events...")
     wait_for_updates(vim) do |property_change|
-      puts property_change.name
+      logger.info(property_change.name)
       next unless property_change.name.match?(/latestPage.*/)
 
       events = Array(property_change.val).map { |event| EventParser.parse_event(event).merge(:ems_id => ems_id) }
-      puts events.to_json
+      logger.info(events.to_json)
       publish_events(events)
     end
   rescue Interrupt
@@ -39,7 +40,7 @@ def stop!
 
   private
 
-  attr_reader :ems_id, :default_endpoint, :default_authentication, :messaging, :page_size
+  attr_reader :ems_id, :default_endpoint, :default_authentication, :logger, :messaging, :page_size
 
   def connect
     vim_opts = {

workers/event_catcher/event_parser.rb

@@ -13,7 +13,6 @@ def self.parse_event(event)
         sub_event_type   = "PowerOnVM_Task"    if event.fullFormattedMessage.to_s.downcase == "task: power on virtual machine"
         sub_event_type ||= "DrsMigrateVM_Task" if event.info&.descriptionId == "Drm.ExecuteVMotionLRO"
         if sub_event_type.nil?
-          puts "Event Type cannot be determined for TaskEvent.  Using generic eventType [TaskEvent] instead"
           sub_event_type = "TaskEvent"
         end
       when "Rename_Task", "Destroy_Task"

workers/event_catcher/worker

@@ -5,6 +5,7 @@ require "bundler/inline"
 gemfile do
   source "https://rubygems.org"
 
+  gem "manageiq-loggers", "~>1.0"
   gem "manageiq-messaging", "~> 1.0"
   gem "rbvmomi2", "~> 3.3"
   gem "sd_notify"
@@ -18,15 +19,20 @@ def setproctitle
   Process.setproctitle(proc_title)
 end
 
+def build_logger
+  ManageIQ::Loggers::Base.new($stdout) # TODO: build container/journal/base logger
+end
+
 def main(args)
   setproctitle
 
-  ems                    = args["ems"].detect { |e| e["type"] == "ManageIQ::Providers::Vmware::InfraManager" }
-  default_endpoint       = ems["endpoints"].detect { |ep| ep["role"] == "default" }
-  default_authentication = ems["authentications"].detect { |auth| auth["authtype"] == "default" }
-  messaging              = args["messaging"].symbolize_keys
+  logger         = build_logger
+  ems            = args["ems"].detect { |e| e["type"] == "ManageIQ::Providers::Vmware::InfraManager" }
+  messaging      = args["messaging"].symbolize_keys
+  endpoint       = ems["endpoints"].detect { |ep| ep["role"] == "default" }
+  authentication = ems["authentications"].detect { |auth| auth["authtype"] == "default" }
 
-  EventCatcher.new(ems["id"], default_endpoint, default_authentication, messaging).run!
+  EventCatcher.new(ems, endpoint, authentication, messaging, logger).run!
 end
 
 def parse_args