Add a setting to allow ESXi hosts to be added

Allow adding an ESXi host directly for development testing if a vCenter
isn't available.

Author: agrare

app/models/manageiq/providers/vmware/infra_manager/vim_connect_mixin.rb

@@ -79,7 +79,7 @@ def raw_connect(options)
           }
         )
 
-        raise MiqException::Error, _("Adding ESX/ESXi Hosts is not supported") unless vim.isVirtualCenter
+        raise MiqException::Error, _("Adding ESX/ESXi Hosts is not supported") if !vim.isVirtualCenter && !Settings.prototype.ems_vmware.allow_direct_hosts
         raise MiqException::Error, _("vCenter version %{version} is unsupported") % {:version => vim.apiVersion} if !version_supported?(vim.apiVersion)
 
         # If the time on the vCenter is very far off from MIQ system time then

config/settings.yml

@@ -60,3 +60,6 @@
         :ems_refresh_worker_vmware_cloud: {}
         :ems_refresh_worker_vmware_cloud_network: {}
         :ems_refresh_worker_vmware_tanzu: {}
+:prototype:
+  :ems_vmware:
+    :allow_direct_hosts: false

spec/models/manageiq/providers/vmware/infra_manager_spec.rb

@@ -71,6 +71,14 @@
         expect { described_class.verify_credentials(verify_params) }
           .to raise_error(MiqException::Error, "Adding ESX/ESXi Hosts is not supported")
       end
+
+      context "with allow_direct_hosts setting set to true" do
+        before { stub_settings_merge(:prototype => {:ems_vmware => {:allow_direct_hosts => true}}) }
+
+        it "is successful" do
+          expect(described_class.verify_credentials(verify_params)).to be_truthy
+        end
+      end
     end
 
     context "vCenter currentTime out of sync" do