Use let for host tests

Author: kbrock

app/models/manageiq/providers/vmware/infra_manager/inventory/saver.rb

@@ -18,7 +18,12 @@ def save_inventory(persister)
   private
 
   def update_ems_refresh_stats(ems, error: nil)
-    ems.update(:last_refresh_error => error, :last_refresh_date => Time.now.utc)
+    refresh_date = Time.now.utc
+
+    ems.last_refresh_error        = error
+    ems.last_refresh_date         = refresh_date
+    ems.last_refresh_success_date = refresh_date if error.nil?
+    ems.save!
   end
 
   def post_refresh(ems, save_inventory_start_time)

spec/models/manageiq/providers/vmware/infra_manager/host_spec.rb

@@ -1,90 +1,83 @@
 describe ManageIQ::Providers::Vmware::InfraManager::Host do
-  before(:each) do
-    @host = FactoryBot.create(:host_vmware)
-  end
+  let(:ems)  { FactoryBot.create(:ems_vmware) }
+  let(:host) { FactoryBot.create(:host_vmware, :ext_management_system => ems) }
 
   context "#reserve_next_available_vnc_port" do
     context "without EMS defaults set" do
-      before(:each) do
-        @ems = FactoryBot.create(:ems_vmware, :host_default_vnc_port_start => nil, :host_default_vnc_port_end => nil)
-        @host.ext_management_system = @ems
-      end
+      let(:ems)  { FactoryBot.create(:ems_vmware, :host_default_vnc_port_start => nil, :host_default_vnc_port_end => nil) }
 
       it "normal case" do
-        @host.update(:next_available_vnc_port => 5901)
+        host.update(:next_available_vnc_port => 5901)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5901)
-        expect(@host.next_available_vnc_port).to eq(5902)
+        expect(host.reserve_next_available_vnc_port).to eq(5901)
+        expect(host.next_available_vnc_port).to eq(5902)
       end
 
       it "with last value of nil" do
-        @host.update(:next_available_vnc_port => nil)
+        host.update(:next_available_vnc_port => nil)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5900)
-        expect(@host.next_available_vnc_port).to eq(5901)
+        expect(host.reserve_next_available_vnc_port).to eq(5900)
+        expect(host.next_available_vnc_port).to eq(5901)
       end
 
       it "with last value at end of range" do
-        @host.update(:next_available_vnc_port => 5999)
+        host.update(:next_available_vnc_port => 5999)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5999)
-        expect(@host.next_available_vnc_port).to eq(5900)
+        expect(host.reserve_next_available_vnc_port).to eq(5999)
+        expect(host.next_available_vnc_port).to eq(5900)
       end
 
       it "with last value before start of range" do
-        @host.update(:next_available_vnc_port => 5899)
+        host.update(:next_available_vnc_port => 5899)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5900)
-        expect(@host.next_available_vnc_port).to eq(5901)
+        expect(host.reserve_next_available_vnc_port).to eq(5900)
+        expect(host.next_available_vnc_port).to eq(5901)
       end
 
       it "with last value after end of range" do
-        @host.update(:next_available_vnc_port => 6000)
+        host.update(:next_available_vnc_port => 6000)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5900)
-        expect(@host.next_available_vnc_port).to eq(5901)
+        expect(host.reserve_next_available_vnc_port).to eq(5900)
+        expect(host.next_available_vnc_port).to eq(5901)
       end
     end
 
     context "with EMS defaults set" do
-      before(:each) do
-        @ems = FactoryBot.create(:ems_vmware, :host_default_vnc_port_start => 5925, :host_default_vnc_port_end => 5930)
-        @host.ext_management_system = @ems
-      end
+      let(:ems)  { FactoryBot.create(:ems_vmware, :host_default_vnc_port_start => 5925, :host_default_vnc_port_end => 5930) }
 
       it "normal case" do
-        @host.update(:next_available_vnc_port => 5926)
+        host.update(:next_available_vnc_port => 5926)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5926)
-        expect(@host.next_available_vnc_port).to eq(5927)
+        expect(host.reserve_next_available_vnc_port).to eq(5926)
+        expect(host.next_available_vnc_port).to eq(5927)
       end
 
       it "with last value of nil" do
-        @host.update(:next_available_vnc_port => nil)
+        host.update(:next_available_vnc_port => nil)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5925)
-        expect(@host.next_available_vnc_port).to eq(5926)
+        expect(host.reserve_next_available_vnc_port).to eq(5925)
+        expect(host.next_available_vnc_port).to eq(5926)
       end
 
       it "with last value at end of range" do
-        @host.update(:next_available_vnc_port => 5930)
+        host.update(:next_available_vnc_port => 5930)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5930)
-        expect(@host.next_available_vnc_port).to eq(5925)
+        expect(host.reserve_next_available_vnc_port).to eq(5930)
+        expect(host.next_available_vnc_port).to eq(5925)
       end
 
       it "with last value before start of range" do
-        @host.update(:next_available_vnc_port => 5924)
+        host.update(:next_available_vnc_port => 5924)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5925)
-        expect(@host.next_available_vnc_port).to eq(5926)
+        expect(host.reserve_next_available_vnc_port).to eq(5925)
+        expect(host.next_available_vnc_port).to eq(5926)
       end
 
       it "with last value after end of range" do
-        @host.update(:next_available_vnc_port => 5931)
+        host.update(:next_available_vnc_port => 5931)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5925)
-        expect(@host.next_available_vnc_port).to eq(5926)
+        expect(host.reserve_next_available_vnc_port).to eq(5925)
+        expect(host.next_available_vnc_port).to eq(5926)
       end
     end
   end