Set vim_clone_options[:snapshot] to VimString.new()

Author: agrare

app/models/manageiq/providers/vmware/infra_manager/provision/cloning.rb

@@ -117,12 +117,18 @@ def start_clone(clone_options)
 
     [:config, :customization, :linked_clone].each { |key| vim_clone_options[key] = clone_options[key] }
 
-    [:folder, :host, :pool, :snapshot].each do |key|
+    [:folder, :host, :pool].each do |key|
       ci = clone_options[key]
       next if ci.nil?
+
       vim_clone_options[key] = ci.ems_ref_obj
     end
 
+    if clone_options[:snapshot]
+      ci = clone_options[:snapshot]
+      vim_clone_options[:snapshot] = VimString.new(ci.ems_ref, ci.ems_ref_type, :ManagedObjectReference) if ci.ems_ref.present? && ci.ems_ref_type.present?
+    end
+
     vim_clone_options[:datastore]       = datastore_ems_ref(clone_options)
     vim_clone_options[:disk]            = build_disk_relocate_spec(vim_clone_options[:datastore])
     vim_clone_options[:storage_profile] = build_storage_profile(clone_options[:storage_profile]) unless clone_options[:storage_profile].nil?

spec/factories/resource_pool.rb

@@ -0,0 +1,6 @@
+FactoryBot.define do
+  factory :resource_pool_vmware, :class => "ManageIQ::Providers::Vmware::InfraManager::ResourcePool", :parent => :resource_pool do
+    sequence(:ems_ref) { |n| "resgroups-#{n}" }
+    ems_ref_type { "ResourcePool" }
+  end
+end

spec/models/manageiq/providers/vmware/infra_manager/provision/cloning_spec.rb

@@ -1,5 +1,6 @@
 describe ManageIQ::Providers::Vmware::InfraManager::Provision::Cloning do
-  let(:ems)               { FactoryBot.create(:ems_vmware_with_authentication) }
+  let(:zone)              { EvmSpecHelper.local_miq_server.zone }
+  let(:ems)               { FactoryBot.create(:ems_vmware_with_authentication, :zone => zone) }
   let(:user_admin)        { FactoryBot.create(:user_admin) }
   let(:template)          { FactoryBot.create(:template_vmware, :name => "template1", :ext_management_system => ems, :cpu_limit => -1, :cpu_reserve => 0) }
   let(:provision)         { FactoryBot.create(:miq_provision_vmware, :userid => user_admin.userid, :miq_request => provision_request, :source => template, :request_type => 'template', :state => 'pending', :status => 'Ok', :options => options) }
@@ -35,4 +36,42 @@
       provision.dest_folder
     end
   end
+
+  context "#start_clone" do
+    let(:folder)    { FactoryBot.create(:vmware_folder_vm, :ext_management_system => ems) }
+    let(:host)      { FactoryBot.create(:host_vmware_esx, :ext_management_system => ems, :ems_ref => "host-1") }
+    let(:pool)      { FactoryBot.create(:resource_pool_vmware, :ext_management_system => ems) }
+    let(:snapshot)  { FactoryBot.create(:snapshot, :ems_ref => "snapshot-1", :ems_ref_type => "Snapshot") }
+    let(:datastore) { FactoryBot.create(:storage_vmware, :ext_management_system => ems) }
+
+    let(:clone_options) do
+      {
+        :name      => "clone test",
+        :folder    => folder,
+        :host      => host,
+        :pool      => pool,
+        :snapshot  => snapshot,
+        :datastore => datastore
+      }
+    end
+
+    # Building the disk relocate spec has to connect to the ems so we need to
+    # stub that out here.
+    before { allow(provision).to receive(:build_disk_relocate_spec) }
+
+    it "converts AR objects to VimTypes" do
+      expect(provision)
+        .to receive(:clone_vm)
+        .with(
+          hash_including(
+            :folder   => folder.ems_ref_obj,
+            :host     => host.ems_ref_obj,
+            :pool     => pool.ems_ref_obj,
+            :snapshot => VimString.new(snapshot.ems_ref, snapshot.ems_ref_type, :ManagedObjectReference)
+          )
+        )
+
+      provision.start_clone(clone_options)
+    end
+  end
 end