Merge pull request #821 from kbrock/local_miq_server

convert create_guid_miq_server_zone to local_miq_server

Author: Fryguy

spec/factories/ext_management_system.rb

@@ -1,9 +1,6 @@
 FactoryBot.define do
   factory :ems_vmware_with_vcr_authentication, :parent => :ems_vmware_cloud do
-    zone do
-      _guid, _server, zone = EvmSpecHelper.create_guid_miq_server_zone
-      zone
-    end
+    zone { EvmSpecHelper.local_miq_server.zone }
 
     after(:build) do |ems|
       ems.hostname = Rails.application.secrets.vmware_cloud[:host]

spec/models/manageiq/providers/vmware/cloud_manager/refresher_spec.rb

@@ -6,7 +6,7 @@
     @hostname = host_uri.host
     @port = host_uri.port == 443 ? nil : host_uri.port
 
-    _guid, _server, zone = EvmSpecHelper.create_guid_miq_server_zone
+    zone = EvmSpecHelper.local_miq_server.zone
     @ems = FactoryBot.create(
       :ems_vmware_cloud,
       :zone        => zone,

spec/models/manageiq/providers/vmware/cloud_manager/vm/reconfigure_spec.rb

@@ -1,5 +1,5 @@
 describe ManageIQ::Providers::Vmware::CloudManager::Vm::Reconfigure do
-  before { EvmSpecHelper.create_guid_miq_server_zone }
+  before { EvmSpecHelper.local_miq_server }
   let(:vm) do
     FactoryBot.create(
       :vm_vmware_cloud,

spec/models/manageiq/providers/vmware/cloud_manager_spec.rb

@@ -11,7 +11,7 @@
   end
 
   before(:example) do
-    _guid, _server, zone = EvmSpecHelper.create_guid_miq_server_zone
+    zone = EvmSpecHelper.local_miq_server.zone
     @ems = FactoryBot.create(
       :ems_vmware_cloud,
       :zone     => zone,

spec/models/manageiq/providers/vmware/container_manager/refresher_spec.rb

@@ -3,7 +3,7 @@
     expect(described_class.ems_type).to eq(:vmware_tanzu)
   end
 
-  let(:zone) { EvmSpecHelper.create_guid_miq_server_zone.last }
+  let(:zone) { EvmSpecHelper.local_miq_server.zone }
   let!(:ems) { FactoryBot.create(:ems_vmware_tanzu_with_vcr_authentication, :zone => zone) }
 
   it "will perform a full refresh" do

spec/models/manageiq/providers/vmware/infra_manager/metric_capture_spec.rb

@@ -4,7 +4,7 @@
   before(:each) do
     MiqRegion.seed
 
-    guid, server, @zone = EvmSpecHelper.create_guid_miq_server_zone
+    @zone = EvmSpecHelper.local_miq_server.zone
 
     Timecop.freeze(Time.parse("2011-08-12T23:33:00Z").utc)
   end

spec/models/manageiq/providers/vmware/infra_manager/provision_workflow_spec.rb

@@ -38,7 +38,7 @@
     subject        { req.workflow(options) }
 
     before do
-      EvmSpecHelper.create_guid_miq_server_zone
+      EvmSpecHelper.local_miq_server
       MiqDialog.seed
     end
 

spec/models/manageiq/providers/vmware/infra_manager/refresher_spec.rb

@@ -4,7 +4,7 @@
   include Spec::Support::EmsRefreshHelper
 
   let!(:ems) do
-    _, _, zone = EvmSpecHelper.create_guid_miq_server_zone
+    zone = EvmSpecHelper.local_miq_server.zone
     hostname = Rails.application.secrets.vmware_infra[:hostname]
     FactoryBot.create(:ems_vmware_with_authentication, :hostname => hostname, :zone => zone).tap do |ems|
       # NOTE: VCR filter_sensitive_data was replacing rootFolder with VMWARE_USERNAME and

spec/models/manageiq/providers/vmware/infra_manager/vm/operations/snapshot_spec.rb

@@ -1,6 +1,6 @@
 describe ManageIQ::Providers::Vmware::InfraManager::Vm::Operations::Snapshot do
   let(:vm) do
-    _, _, zone = EvmSpecHelper.create_guid_miq_server_zone
+    zone = EvmSpecHelper.local_miq_server.zone
     ems = FactoryBot.create(:ems_vmware, :zone => zone)
     host = FactoryBot.create(:host_vmware, :ext_management_system => ems)
     FactoryBot.create(:vm_vmware, :ext_management_system => ems, :host => host)

spec/models/manageiq/providers/vmware/infra_manager/vm/remote_console_spec.rb

@@ -152,7 +152,7 @@
     let(:vm) { FactoryBot.create(:vm_with_ref, :ext_management_system => ems, :host => host) }
 
     it 'normal case' do
-      EvmSpecHelper.create_guid_miq_server_zone
+      EvmSpecHelper.local_miq_server
       ems.update(:ipaddress => '192.168.252.14', :hostname => '192.168.252.14')
       auth = FactoryBot.create(:authentication,
                                :userid   => 'dev1',