Merge remote-tracking branch 'origin/master' into spassky

Author: Fryguy

.github/workflows/yarn_lock.yaml

@@ -15,7 +15,7 @@ jobs:
     - name: Set up Node
       uses: actions/setup-node@v4
       with:
-        node-version: "18"
+        node-version: "20"
         cache: yarn
         registry-url: https://npm.manageiq.org/
     - name: Update yarn.lock

.yarn/releases/yarn-4.9.1.cjs renamed to .yarn/releases/yarn-4.9.2.cjs

@@ -27,4 +27,4 @@ npmAuditExcludePackages:
   # pending | moderate | GHSA-jpcq-cgw6-v4j6 | jquery >=1.0.3 <3.5.0  | 2.2.4, 3.4.1 brought in by manageiq-ui-classic@workspace:., patternfly@npm:3.59.5
   # pending | moderate | GHSA-rmxg-73gg-4p98 | jquery >=1.12.3 <3.0.0 | 2.2.4 brought in by manageiq-ui-classic@workspace:.
 
-yarnPath: .yarn/releases/yarn-4.9.1.cjs
+yarnPath: .yarn/releases/yarn-4.9.2.cjs

.yarnrc.yml

@@ -8,8 +8,6 @@
 
 [![Chat](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/ManageIQ/manageiq/ui?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 
-[![Build history for spassky branch](https://buildstats.info/github/chart/ManageIQ/manageiq-ui-classic?branch=spassky&buildCount=50&includeBuildsFromPullRequest=false&showstats=false)](https://github.com/ManageIQ/manageiq-ui-classic/actions?query=branch%3Amaster)
-
 ManageIQ UI Classic is the UI that has been split out of the main [manageiq repo](https://github.com/ManageIQ/manageiq).
 
 ## Development Setup

README.md

@@ -86,11 +86,6 @@ namespace :spec do
 
   namespace :cypress do
     task :run_with_rails do
-      # Set the rate limit to a large number to avoid 429: Too Many Requests errors
-      # which can occur as cypress very quickly hits a lots of endpoints.
-      puts "\n== Removing rate limit =="
-      exit $?.exitstatus unless system("bundle exec rails runner 'MiqServer.my_server.add_settings_for_resource(:server => {:rate_limiting => {:request => {:limit => 99999}, :ui_login => {:limit => 99999}}})'")
-
       puts "\n== Starting Rails server =="
       rails_pid = Bundler.with_original_env do
         spawn("bin/rails s", [:out, :err] => "/dev/null")

Rakefile

@@ -349,7 +349,7 @@ def syncvms
   # Refresh the power states for selected or single VMs
   def refreshvms(privilege = DEFAULT_PRIVILEGE)
     if privilege == DEFAULT_PRIVILEGE
-      ActiveSupport::Deprecation.warn(<<-MSG.strip_heredoc)
+      Vmdb::Deprecation.warn(<<-MSG.strip_heredoc, caller_locations[1..-1])
       Please pass the privilege you want to check for when refreshing
       MSG
       privilege = params[:pressed]

app/controllers/application_controller/ci_processing.rb

@@ -128,7 +128,10 @@ def cancel_task
   # Delete selected tasks
   def delete_tasks
     assert_privileges("miq_task_delete")
-    delete_tasks_from_table(find_checked_items, "Delete selected tasks")
+
+    new_checked_items = find_checked_items.select { |item| params["select-row-#{item}"] == "on" }
+
+    delete_tasks_from_table(new_checked_items, "Delete selected tasks")
     jobs
     @refresh_partial = "layouts/tasks"
   end

app/controllers/miq_task_controller.rb

@@ -4,7 +4,6 @@ import PropTypes from 'prop-types';
 import { FormSpy } from '@data-driven-forms/react-form-renderer';
 import createSchema from './settings-tasks-form.schema';
 import loadTable from './load-table-helper';
-import GtlView from '../gtl-view';
 
 const SettingsTasksForm = ({
   allTasks, zones, users, timePeriods, taskStates, tz,
@@ -47,7 +46,6 @@ const SettingsTasksForm = ({
           loadDefaultTable();
         }}
       />
-      <GtlView showUrl="/miq_task/show" />
     </div>
   );
 };

app/javascript/components/settings-tasks-form/index.jsx

@@ -24,28 +24,17 @@ export function convert(resource) {
 }
 
 export function load(useLimit) {
-  const promises = [];
   const limitFragment = useLimit ? `&limit=${maxNotifications}` : '';
 
-  promises.push(API.get(`/api/notifications?expand=resources&attributes=details&sort_by=id&sort_order=desc${limitFragment}`)
+  return API.get(`/api/notifications?expand=resources&attributes=details&sort_by=id&sort_order=desc${limitFragment}`)
     .then((data) => {
       const notifications = data.resources.map(convert);
 
       return {
         notifications,
-        subcount: data.subcount,
+        subcount: data.count
       };
-    }));
-
-  if (useLimit) {
-    // get real subcount
-    promises.push(API.get('/api/notifications'));
-  }
-
-  return Promise.all(promises).then(([{ notifications, subcount }, meta]) => ({
-    notifications,
-    subcount: meta ? meta.subcount : subcount,
-  }));
+    });
 }
 
 const bulkAction = (action) => (notifications) => API.post(`/api/notifications/`, {