Skip to content

Commit 0f7695a

Browse files
Updated schedule form tests to use flashClassMap
1 parent 9de4011 commit 0f7695a

File tree

1 file changed

+11
-20
lines changed

1 file changed

+11
-20
lines changed

cypress/e2e/ui/Settings/Application-Settings/schedule.cy.js

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
/* eslint-disable no-undef */
2+
import { flashClassMap } from '../../../../support/assertions/assertion_constants';
23

34
const textConstants = {
45
// List items
@@ -49,12 +50,6 @@ const textConstants = {
4950
settingsMenuOption: 'Settings',
5051
appSettingsMenuOption: 'Application Settings',
5152

52-
// Flash message types
53-
flashTypeSuccess: 'success',
54-
flashTypeWarning: 'warning',
55-
flashTypeError: 'error',
56-
flashTypeInfo: 'info',
57-
5853
// Flash message text snippets
5954
flashMessageScheduleQueued: 'queued to run',
6055
flashMessageOperationCanceled: 'cancelled',
@@ -107,10 +102,6 @@ const {
107102
deleteScheduleConfigOption,
108103
schedulesAccordionItem,
109104
configToolbarButton,
110-
flashTypeSuccess,
111-
flashTypeWarning,
112-
flashTypeError,
113-
flashTypeInfo,
114105
flashMessageScheduleQueued,
115106
flashMessageOperationCanceled,
116107
flashMessageScheduleDisabled,
@@ -171,7 +162,7 @@ function deleteSchedule(scheduleName = initialScheduleName) {
171162
confirmTriggerFn: () => selectConfigMenu(deleteScheduleConfigOption),
172163
containsText: browserAlertDeleteConfirmText,
173164
});
174-
cy.expect_flash(flashTypeSuccess, flashMessageScheduleDeleted);
165+
cy.expect_flash(flashClassMap.success, flashMessageScheduleDeleted);
175166
}
176167

177168
function interceptGetScheduleDetailsApi(scheduleName = initialScheduleName) {
@@ -387,13 +378,13 @@ describe('Automate Schedule form operations: Settings > Application Settings > S
387378
)
388379
.should('be.enabled')
389380
.click();
390-
cy.expect_flash(flashTypeSuccess, flashMessageOperationCanceled);
381+
cy.expect_flash(flashClassMap.success, flashMessageOperationCanceled);
391382
});
392383

393384
it('Checking whether add, edit & delete schedule works', () => {
394385
/* ===== Adding a schedule ===== */
395386
addSchedule();
396-
cy.expect_flash(flashTypeSuccess, flashMessageScheduleSaved);
387+
cy.expect_flash(flashClassMap.success, flashMessageScheduleSaved);
397388

398389
/* ===== Editing a schedule ===== */
399390
// Selecting the schedule and intercepting the API call to get schedule details
@@ -406,7 +397,7 @@ describe('Automate Schedule form operations: Settings > Application Settings > S
406397
cy.contains('#main-content .bx--btn-set button[type="submit"]', saveButton)
407398
.should('be.enabled')
408399
.click();
409-
cy.expect_flash(flashTypeSuccess, flashMessageScheduleSaved);
400+
cy.expect_flash(flashClassMap.success, flashMessageScheduleSaved);
410401

411402
/* ===== Delete is already handled from afterEach hook ===== */
412403
});
@@ -425,7 +416,7 @@ describe('Automate Schedule form operations: Settings > Application Settings > S
425416
)
426417
.should('be.enabled')
427418
.click();
428-
cy.expect_flash(flashTypeSuccess, flashMessageOperationCanceled);
419+
cy.expect_flash(flashClassMap.success, flashMessageOperationCanceled);
429420

430421
/* ===== Checking whether Reset button works ===== */
431422
// Selecting the schedule and intercepting the API call to get schedule details
@@ -437,7 +428,7 @@ describe('Automate Schedule form operations: Settings > Application Settings > S
437428
cy.contains('#main-content .bx--btn-set button[type="button"]', resetButton)
438429
.should('be.enabled')
439430
.click();
440-
cy.expect_flash(flashTypeWarning, flashMessageResetSchedule);
431+
cy.expect_flash(flashClassMap.warning, flashMessageResetSchedule);
441432
// Confirming the edited fields contain the old values after resetting
442433
cy.get('input#description').should('have.value', initialDescription);
443434
cy.get('input#start_date').should('have.value', initialStartDate);
@@ -452,7 +443,7 @@ describe('Automate Schedule form operations: Settings > Application Settings > S
452443

453444
/* ===== Trying to add the same schedule again ===== */
454445
addSchedule();
455-
cy.expect_flash(flashTypeError, flashMessageFailedToAddSchedule);
446+
cy.expect_flash(flashClassMap.error, flashMessageFailedToAddSchedule);
456447
});
457448

458449
it('Checking whether Disabling, Enabling & Queueing up the schedule works', () => {
@@ -463,15 +454,15 @@ describe('Automate Schedule form operations: Settings > Application Settings > S
463454

464455
/* ===== Disabling the schedule ===== */
465456
selectConfigMenu(disableScheduleConfigOption);
466-
cy.expect_flash(flashTypeInfo, flashMessageScheduleDisabled);
457+
cy.expect_flash(flashClassMap.info, flashMessageScheduleDisabled);
467458

468459
/* ===== Enabling the schedule ===== */
469460
selectConfigMenu(enableScheduleConfigOption);
470-
cy.expect_flash(flashTypeInfo, flashMessageScheduleEnabled);
461+
cy.expect_flash(flashClassMap.info, flashMessageScheduleEnabled);
471462

472463
/* ===== Queueing-up the schedule ===== */
473464
selectConfigMenu(queueScheduleConfigOption);
474-
cy.expect_flash(flashTypeSuccess, flashMessageScheduleQueued);
465+
cy.expect_flash(flashClassMap.success, flashMessageScheduleQueued);
475466
});
476467

477468
afterEach(() => {

0 commit comments

Comments
 (0)