Merge pull request #9367 from GilbertCherrie/fix_searchbar_security_issue

Fix searchbar formtoken issue

Author: Fryguy

app/javascript/components/search-bar/index.jsx

@@ -9,10 +9,6 @@ import {
 } from '@carbon/icons-react';
 
 const SearchBar = ({ searchText, advancedSearch, action }) => {
-  const formToken = () => {
-    const csrfToken = document.querySelector('meta[name=csrf-token]');
-    return csrfToken ? csrfToken.getAttribute('content') : '';
-  };
   const [data, setData] = useState({
     formText: searchText || '',
     loading: false,
@@ -96,7 +92,7 @@ const SearchBar = ({ searchText, advancedSearch, action }) => {
   return (
     <div className="search_bar">
       <Form onSubmit={onSearch} method="post" id="search-bar-form">
-        <input type="hidden" name="authenticity_token" value={formToken()} />
+        <input type="hidden" name="authenticity_token" />
         <TextInput
           id="search_text"
           labelText={__('Search')}

app/javascript/spec/search-bar/__snapshots__/search-bar.spec.js.snap

@@ -12,7 +12,6 @@ exports[`Search Bar component should render the search bar component 1`] = `
     <input
       name="authenticity_token"
       type="hidden"
-      value=""
     />
     <TextInput
       hideLabel={true}
@@ -73,7 +72,6 @@ exports[`Search Bar component should render the search bar component with advanc
     <input
       name="authenticity_token"
       type="hidden"
-      value=""
     />
     <TextInput
       hideLabel={true}
@@ -134,7 +132,6 @@ exports[`Search Bar component should render the search bar component with search
     <input
       name="authenticity_token"
       type="hidden"
-      value=""
     />
     <TextInput
       hideLabel={true}