Skip to content

Commit 6efbb08

Browse files
committed
rexml 3.4.3 Document.new no longer accepts strings with no root element
Followup to ManageIQ/manageiq-gems-pending#614 We generally create the xml document and add the root element and others afterwards. This is ok, but we need to call REXML::Document.new(nil) instead. In 3.4.3 and future versions, it fails validation when the string provided to .new does not contain a root element. See the discussion in: https://www.github.com/ruby/rexml/pull/291
1 parent 569223d commit 6efbb08

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

app/controllers/miq_ae_class_controller.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ def class_and_glyph(cls)
401401
end
402402

403403
def build_details_grid(view, mode = true)
404-
xml = REXML::Document.load("")
404+
xml = REXML::Document.load(nil)
405405
xml << REXML::XMLDecl.new(1.0, "UTF-8")
406406

407407
# Create root element

0 commit comments

Comments
 (0)